Emscripten addons not linking

[ofTheo]

Building with emscripten latest on macOS with current nightly.
Running emmake make Release I see a bunch of errors relating to metalangle.

• 1 Metal Angle Errors

In file included from In file included from ../../../libs/metalangle/include/third_party/jsoncpp/source/include/json/features.h../../../libs/metalangle/include/third_party/jsoncpp/source/include/json/forwards.h::10:
In file included from 10../../../libs/metalangle/include/third_party/jsoncpp/source/include/json/forwards.h:
:In file included from 10../../../libs/metalangle/include/third_party/jsoncpp/source/include/json/config.h:
:In file included from 10../../../libs/metalangle/include/third_party/jsoncpp/source/include/json/config.h:
:In file included from 10/Users/theo/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/istream:
:In file included from 163/Users/theo/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/istream:
:In file included from 163/Users/theo/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/__fwd/istream.h:
:In file included from 13/Users/theo/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/__fwd/istream.h:
:13:
/Users/theo/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/__fwd/string.h:/Users/theo/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/__fwd/string.h22:22::11::  error: error: templates must have C++ linkagetemplates must have C++ linkage

Removing the metalangle folder from libs/ fixed it.

• 2 ASSERTIONS warning - not critical
  -s ASSERTIONS=2
  These flags need to be commented out.

Once the metalangle issue is addressed Emscripten builds and runs again!!
Yay. Huge thanks to @danoli3 @Jonathhhan and anyone else who contributed to getting it working. Huge to have it back!

[ofTheo]

I think the issue with metalangle is coming from the includes and the way the makefiles tries to grab every folder in libs/
So if metalangle is going to ship with OF it needs to be added to an exclude for emscripten ( and maybe other platforms too )

You can see that it only has a macOS lib so emscripten shouldn't be trying to include it

Edit: seems simple.
I'll do a PR with these changes.

[ofTheo]

Additional issue with ofxAssimp addons

throw new Error(`bad export type for '${symName}': ${typeof value}`);                  
Error: bad export type for 'aiReleasePropertyStore': undefined

Looks like maybe a newer or older assimp version or some other issue with the emscripten apothecary build of assimp.
( macOS in the same nightly builds fine ) .

The function is there in assimp/cimport.h
ASSIMP_API void aiReleasePropertyStore(C_STRUCT aiPropertyStore *p);

[danoli3]

Yay! assimp maybe hidden inline functions. lets see after openframeworks/apothecary#495

[ofTheo]

Still seeing the aiReleasePropertyStore error in latest nightly.
I wonder if it's getting defined differently on emscripten configure and so the include/ folder from macOS is causing issues?

Error: bad export type for 'aiReleasePropertyStore': undefined
    at reportUndefinedSymbols (/private/var/folders/07/q52mwt2x0yxflh4swc2tdj600000gn/T/emscripten_temp_980h2ibb/tsgen.js:2459:19)
    at loadDylibs (/private/var/folders/07/q52mwt2x0yxflh4swc2tdj600000gn/T/emscripten_temp_980h2ibb/tsgen.js:2467:9)
    at receiveInstance (/private/var/folders/07/q52mwt2x0yxflh4swc2tdj600000gn/T/emscripten_temp_980h2ibb/tsgen.js:850:5)
    at receiveInstantiationResult (/private/var/folders/07/q52mwt2x0yxflh4swc2tdj600000gn/T/emscripten_temp_980h2ibb/tsgen.js:870:12)
    at createWasm (/private/var/folders/07/q52mwt2x0yxflh4swc2tdj600000gn/T/emscripten_temp_980h2ibb/tsgen.js:904:19)

[ofTheo]

Okay that's the issue.
Taking the include/ folder from the emscripten apothecary compilation of assimp and using that works.

I'll see if I can find a good fix based on a diff of the two.

[danoli3]

an idea since macOS includes uses the inbuilt xcframeworks with include folder inside it, we can pretty just override the include folder for emscripten when installing the nightly onto of that include folder

[ofTheo]

Hmm that wasn't the issue sadly, I was just building apothecary with master locally instead of bleeding. ( face palm )

Building with bleeding locally works, but the libs downloaded via GH actions on apothecary nightly don't, so I wonder if there is something with the emscripten version as that would be the only difference.

I am using the latest release of emscipten right now.
version: 4.0.3 (a9651ff57165f5710bb09a5fe52590fd6ddb72df)

[ofTheo]

Okay I have a fix that avoids storing the C ptr in the shared_ptr and removes it from the .h all together.
That way the function gets exported properly.

Will prob be needed for both versions of the assimp addons. Will put together a PR for it.