Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conflict additives variants and and #8905

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

benbenben2
Copy link
Collaborator

What

Fixes #7927, see issue for more explanations

I have some difficulties with the tests locally. Many tests not related to this PR are failing locally.

Screenshot

01_Croatian_1

@benbenben2 benbenben2 requested a review from a team as a code owner August 24, 2023 20:42
@benbenben2 benbenben2 self-assigned this Aug 24, 2023
@github-actions github-actions bot added 🥗 Ingredients 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Aug 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. All tests pass locally for me.

@stephanegigandet stephanegigandet merged commit c8d6e44 into main Aug 28, 2023
13 checks passed
@stephanegigandet stephanegigandet deleted the fix_conflict_additives_variants_and_and branch August 28, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingredients parsing issue - Croatian - "E500 i E503" becomes "E500i", "E503"
2 participants