Skip to content

Conversation

ovindu-a
Copy link
Contributor

@ovindu-a ovindu-a commented Oct 1, 2024

Description

I have reduced the default retry behavior from 15 retries to 3 as requested in issue #417

References

closes #417

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ovindu-a ovindu-a requested a review from a team as a code owner October 1, 2024 09:20
Copy link

linux-foundation-easycla bot commented Oct 1, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@ewanharris
Copy link
Member

Thanks for the PR @ovindu-a!

We're currently in the process of porting some changes from the individual SDK repos back to this one so we're not ready to merge this yet, but I've added the hacktoberfest-accepted label so that this gets tracked correctly.

@ovindu-a
Copy link
Contributor Author

Oh I see. No worries @ewanharris. Please let me know if there's any other issues I can work on.

@rhamzeh rhamzeh added this pull request to the merge queue Nov 27, 2024
@rhamzeh
Copy link
Member

rhamzeh commented Nov 27, 2024

Thanks for the PR @ovindu-a!

@rhamzeh rhamzeh changed the title fix : change default retry policy (#417) fix : change default retry policy Nov 27, 2024
Merged via the queue into openfga:main with commit b35f057 Nov 27, 2024
10 checks passed
rhamzeh pushed a commit to openfga/dotnet-sdk that referenced this pull request Mar 28, 2025
rhamzeh pushed a commit to openfga/dotnet-sdk that referenced this pull request Apr 21, 2025
github-merge-queue bot pushed a commit to openfga/dotnet-sdk that referenced this pull request May 9, 2025
* fix: only retry requests up to 3 times by default (reduced from 15)

Generator PR: openfga/sdk-generator#420

* chore(docs): replace readable names with uuid to discourage storing PII in OpenFGA

Generator PR: openfga/sdk-generator#433

* chore: update api definition, support assertion context & contextual tuples

* chore!: update the name request & response interfaces of BatchCheck

This is in preparation to support server-side BatchCheck

* feat: add contextual tuples to Expand API

api pr: openfga/api#202

* feat: add support for start time in read changes request

* fix: send the start time to ReadChanges in the format the API expects

* fix: list relations should not swallow errors

closes #95

* feat: support contextual tuples in Expand

* chore(docs): update CHANGELOG with unreleased changes

* feat!: add support for filtering stores by name

---------

Co-authored-by: Ovindu Atukorala <ovindu.atukorala@gmail.com>
Co-authored-by: sccalabr <4111230+sccalabr@users.noreply.github.com>
Co-authored-by: Ryan Quinn <ryanpq@gmail.com>
Co-authored-by: Ewan Harris <ewanharris93@gmail.com>
@rhamzeh rhamzeh mentioned this pull request Sep 30, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The default retry policy is too permissive

3 participants