-
Notifications
You must be signed in to change notification settings - Fork 57
fix : change default retry policy #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
Thanks for the PR @ovindu-a! We're currently in the process of porting some changes from the individual SDK repos back to this one so we're not ready to merge this yet, but I've added the |
Oh I see. No worries @ewanharris. Please let me know if there's any other issues I can work on. |
rhamzeh
approved these changes
Nov 27, 2024
Thanks for the PR @ovindu-a! |
4 tasks
4 tasks
4 tasks
rhamzeh
pushed a commit
to openfga/dotnet-sdk
that referenced
this pull request
Mar 28, 2025
4 tasks
rhamzeh
pushed a commit
to openfga/dotnet-sdk
that referenced
this pull request
Apr 21, 2025
github-merge-queue bot
pushed a commit
to openfga/dotnet-sdk
that referenced
this pull request
May 9, 2025
* fix: only retry requests up to 3 times by default (reduced from 15) Generator PR: openfga/sdk-generator#420 * chore(docs): replace readable names with uuid to discourage storing PII in OpenFGA Generator PR: openfga/sdk-generator#433 * chore: update api definition, support assertion context & contextual tuples * chore!: update the name request & response interfaces of BatchCheck This is in preparation to support server-side BatchCheck * feat: add contextual tuples to Expand API api pr: openfga/api#202 * feat: add support for start time in read changes request * fix: send the start time to ReadChanges in the format the API expects * fix: list relations should not swallow errors closes #95 * feat: support contextual tuples in Expand * chore(docs): update CHANGELOG with unreleased changes * feat!: add support for filtering stores by name --------- Co-authored-by: Ovindu Atukorala <ovindu.atukorala@gmail.com> Co-authored-by: sccalabr <4111230+sccalabr@users.noreply.github.com> Co-authored-by: Ryan Quinn <ryanpq@gmail.com> Co-authored-by: Ewan Harris <ewanharris93@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have reduced the default retry behavior from 15 retries to 3 as requested in issue #417
References
closes #417
Review Checklist
main