Skip to content

Conversation

sujitha-av
Copy link
Contributor

Description

Based on this issue in the openfga repo, it was required to add contextual tuples support to the Expand API. And @miparnisari had broken down the steps for the same. This PR does the first step mentioned, to add contextual tuples to the Expand API.

The technical documentation has been skipped.

References

Reference issue

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@sujitha-av sujitha-av requested review from a team as code owners October 7, 2024 14:37
Copy link

linux-foundation-easycla bot commented Oct 7, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sujitha-av / name: Sujitha A V (50d1c0a)

@sujitha-av sujitha-av force-pushed the contextual-tuples-expand-api branch from b0500ee to c4517f4 Compare October 7, 2024 14:44
Copy link
Contributor

@miparnisari miparnisari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After applying the suggestion I made, please run make before commiting. Thanks!

miparnisari
miparnisari previously approved these changes Oct 15, 2024
@miparnisari
Copy link
Contributor

@sujitha-av looks like there is a conflict with main. Could you please git merge origin/main?

@rhamzeh
Copy link
Member

rhamzeh commented Oct 15, 2024

@miparnisari please make sure not to merge this until the relevant openfga/openfga PR is ready to be merged, otherwise autogenerated SDKs & Docs would be wrong

@sujitha-av sujitha-av force-pushed the contextual-tuples-expand-api branch from be89aa5 to 50d1c0a Compare October 31, 2024 19:17
@miparnisari miparnisari merged commit ee46d67 into openfga:main Nov 4, 2024
7 checks passed
rhamzeh added a commit to openfga/dotnet-sdk that referenced this pull request Mar 28, 2025
rhamzeh added a commit to openfga/dotnet-sdk that referenced this pull request Mar 28, 2025
rhamzeh added a commit to openfga/dotnet-sdk that referenced this pull request Mar 28, 2025
rhamzeh added a commit to openfga/dotnet-sdk that referenced this pull request Apr 21, 2025
github-merge-queue bot pushed a commit to openfga/dotnet-sdk that referenced this pull request May 9, 2025
* fix: only retry requests up to 3 times by default (reduced from 15)

Generator PR: openfga/sdk-generator#420

* chore(docs): replace readable names with uuid to discourage storing PII in OpenFGA

Generator PR: openfga/sdk-generator#433

* chore: update api definition, support assertion context & contextual tuples

* chore!: update the name request & response interfaces of BatchCheck

This is in preparation to support server-side BatchCheck

* feat: add contextual tuples to Expand API

api pr: openfga/api#202

* feat: add support for start time in read changes request

* fix: send the start time to ReadChanges in the format the API expects

* fix: list relations should not swallow errors

closes #95

* feat: support contextual tuples in Expand

* chore(docs): update CHANGELOG with unreleased changes

* feat!: add support for filtering stores by name

---------

Co-authored-by: Ovindu Atukorala <ovindu.atukorala@gmail.com>
Co-authored-by: sccalabr <4111230+sccalabr@users.noreply.github.com>
Co-authored-by: Ryan Quinn <ryanpq@gmail.com>
Co-authored-by: Ewan Harris <ewanharris93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants