Skip to content

Conversation

@ewanharris
Copy link
Member

@ewanharris ewanharris commented Jun 28, 2024

Description

This PR ports the changes required for JS metrics across to the generator, unfortunately this required the re-introduction of a patch file 😞. This is because the metrics are context specific (some have storeId to send, some have user info to send) but the mustache templates are logic-less, so we can't say "add this if it's the check method".

To break the commits down:

  • 675e658 - dependabot changes
  • 079dfc3 - copying the metrics changes, adding patch file
  • 1cf0634 - release commit

References

openfga/js-sdk#117

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested a review from a team as a code owner June 28, 2024 13:07
@ewanharris ewanharris mentioned this pull request Jun 28, 2024
4 tasks
@ewanharris ewanharris added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit f85ba12 Jun 28, 2024
@ewanharris ewanharris deleted the js-release/v0.6.0 branch June 28, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants