-
Couldn't load subscription status.
- Fork 22
release: v0.6.0 #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v0.6.0 #119
Conversation
This is mostly some whitespace changes, license headers, and reordering of things as a consequence of how this change had to be integrated into the generator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 83.48% 83.48%
=======================================
Files 19 19
Lines 1005 1005
Branches 176 176
=======================================
Hits 839 839
Misses 78 78
Partials 88 88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ewanharris do you think we can add the metrics you have documented in the PR to the README? (can be in a follow up PR, does not block release)
Even better if we can have a metrics section in the README that links to docs/OTEL_METRICS.md so as not to clutter the readme.
Please also add a note in both that the metrics are not sent if not configured, and will go to the user's OTEL collector, not to the OpenFGA team, in case the wording scares folks.
|
@rhamzeh, ah yeah I shoulda thought of that. I'll add it in this PR a it'll then be on the npm docs too |
Description
Releasing the OpenTelemetry metrics changes. The first commit is mostly some whitespace changes, license headers, and reordering of things as a consequence of how this change had to be integrated into the generator.
References
Generated from openfga/sdk-generator#383
Review Checklist
main