Skip to content

Conversation

bmcustodio
Copy link
Contributor

@bmcustodio bmcustodio commented Nov 26, 2019

Description

This PR adds support for durable queue subscriptions while maintaing the implementation backwards-compatibility.

Motivation and Context

  • I have raised an issue to propose this change (required)

#75.

How Has This Been Tested?

Using the steps described in #75 while using the bmcstdio/openfaas-nats-queue-worker:nats-durable-queue-subscription image.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
@bmcustodio
Copy link
Contributor Author

@alexellis can we get this merged please? 🙏

@bmcustodio bmcustodio mentioned this pull request Dec 10, 2019
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit f272847 into openfaas:master Dec 10, 2019
@alexellis
Copy link
Member

Thanks for the PR.

Something to note from the NATS team - durable subscriptions are not "cleaned up" when you disconnect, so you'd have to do that manually if they are named.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants