Skip to content

Conversation

bmcustodio
Copy link
Contributor

Description

This PR bumps the versions of openfaas/queue-worker and openfaas/gateway used in the Helm chart, and adds support for customising the NATS Streaming channel, queue group and durability.

Motivation and Context

  • I have raised an issue to propose this change (required)

This comes as a follow-up to the merge of openfaas/nats-queue-worker#76 and openfaas/nats-queue-worker#79, and of the corresponding changes in https://github.com/openfaas/faas.

How Has This Been Tested?

By rendering the Helm chart and making sure everything is OK.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 006d913 into openfaas:master Dec 10, 2019
@bmcustodio bmcustodio deleted the bmcstdio-bump-queue-worker branch December 10, 2019 12:20
@alexellis
Copy link
Member

FYI make charts has been run and a new version of the chart was published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants