Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

ignore key_server_cluster randomly failing tests #9639

Merged
merged 3 commits into from
Sep 25, 2018
Merged

ignore key_server_cluster randomly failing tests #9639

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70ead78
ignore key_server_cluster randomly failing tests, related to #9635
debris Sep 24, 2018
070f5fb
Merge branch 'master' into key-server-cluster-ignore
debris Sep 25, 2018
4084571
added explanation comment to test #[ignore]
debris Sep 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions secret_store/src/key_server_cluster/cluster.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1432,6 +1432,7 @@ pub mod tests {
}

#[test]
#[ignore]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to see a comment explaining why a test ignored, this helps later on checking on this case and also understanding the reasoning behind this.
I think the link to #9635 would be good here.

fn schnorr_signing_session_completes_if_node_does_not_have_a_share() {
//::logger::init_log();
let mut core = Core::new().unwrap();
Expand Down Expand Up @@ -1481,6 +1482,7 @@ pub mod tests {
}

#[test]
#[ignore]
fn ecdsa_signing_session_completes_if_node_does_not_have_a_share() {
//::logger::init_log();
let mut core = Core::new().unwrap();
Expand Down