This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
ignore key_server_cluster randomly failing tests #9639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
svyatonik
approved these changes
Sep 25, 2018
svyatonik
added
A8-looksgood 🦄
tomusdrw
approved these changes
Sep 25, 2018
| @@ -1432,6 +1432,7 @@ pub mod tests { | |||
| } | |||
|
|
|||
| #[test] | |||
| #[ignore] | |||
There was a problem hiding this comment.
I like to see a comment explaining why a test ignored, this helps later on checking on this case and also understanding the reasoning behind this.
I think the link to #9635 would be good here.
sorpaas
approved these changes
Sep 25, 2018
There was a problem hiding this comment.
LGTM as a temporary solution. Two comments:
- Those failings are likely just caused by slow CI. One way to re-enable those tests in the short term is just to change
TIMEOUTto be a higher value (rather than 300ms). - For the long term, we should consider changing the
TIMEOUTto use exponential back-off (same strategy used by many other async tests, such as in gnu toolchain).
andresilva
approved these changes
Sep 25, 2018
There was a problem hiding this comment.
LGTM. Similar to what @sorpaas suggested when writing tests that rely on timeouts we could have a dillation factor, all timeouts would be multiplied by this factor. This way we could have a global parameter to tune the tests to run properly on slower machines (it's still flaky though).
dvdplm
added a commit
that referenced
this pull request
Sep 27, 2018
…mon-deps * origin/master: ethereum libfuzzer integration small change (#9547) cli: remove reference to --no-ui in --unlock flag help (#9616) remove master from releasable branches (#9655) ethcore/VerificationQueue don't spawn up extra `worker-threads` when explictly specified not to (#9620) RPC: parity_getBlockReceipts (#9527) Remove unused dependencies (#9589) ignore key_server_cluster randomly failing tests (#9639) ethcore: handle vm exception when estimating gas (#9615) fix bad-block reporting no reason (#9638) Use static call and apparent value transfer for block reward contract code (#9603) HF in POA Sokol (2018-09-19) (#9607) bump smallvec to 0.6 in ethcore-light, ethstore and whisper (#9588) Add constantinople conf to EvmTestClient. (#9570)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #9635