This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add constantinople conf to EvmTestClient. #9570
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,215 @@ | ||
| { "block": | ||
| [ | ||
|
|
||
| { | ||
| "reference": 9568, | ||
|
There was a problem hiding this comment. Can you change this type to a string? Sometimes it may be easier to reference it via |
||
| "failing": "stCreateTest", | ||
| "subtests": [ | ||
| "CreateOOGafterInitCodeRevert_d0g0v0_Constantinople", | ||
| "CreateOOGafterInitCodeReturndata3_d0g0v0_Constantinople", | ||
| "CreateOOGafterInitCodeRevert2_d0g0v0_Constantinople", | ||
| "CreateOOGafterInitCode_d0g1v0_Constantinople", | ||
| "CreateOOGafterInitCodeReturndataSize_d0g0v0_Constantinople", | ||
| "CreateOOGafterInitCode_d0g0v0_Constantinople", | ||
| "CreateOOGafterInitCodeReturndata2_d0g0v0_Constantinople", | ||
|
There was a problem hiding this comment. Please cherry-pick 544f6a3 |
||
| "CreateOOGafterInitCodeReturndata_d0g1v0_Constantinople", | ||
| "CreateOOGafterInitCodeReturndata2_d0g1v0_Constantinople", | ||
| "CreateOOGafterInitCodeReturndata_d0g0v0_Constantinople" | ||
| ] | ||
| }, | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stEIP158Specific", | ||
| "subtests": [ | ||
| "callToEmptyThenCallError_d0g0v0_Byzantium", | ||
| "callToEmptyThenCallError_d0g0v0_Constantinople", | ||
| "callToEmptyThenCallError_d0g0v0_EIP158" | ||
| ] | ||
| }, | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stPreCompiledContracts", | ||
| "subtests": [ | ||
| "identity_to_smaller_d0g0v0_Constantinople", | ||
| "identity_to_bigger_d0g0v0_Constantinople" | ||
| ] | ||
| }, | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stReturnDataTest", | ||
| "subtests": [ | ||
| "modexp_modsize0_returndatasize_d0g1v0_Constantinople", | ||
| "modexp_modsize0_returndatasize_d0g2v0_Constantinople", | ||
| "modexp_modsize0_returndatasize_d0g3v0_Constantinople" | ||
| ] | ||
| }, | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stRevertTest", | ||
| "subtests": [ | ||
| "RevertOnEmptyStack_d0g0v0_Constantinople" | ||
|
There was a problem hiding this comment. Looks like this is fixed? Right now what I get from |
||
| ] | ||
| }, | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stSpecialTest", | ||
| "subtests": [ | ||
| "FailedCreateRevertsDeletion_d0g0v0_Constantinople", | ||
|
There was a problem hiding this comment. This one doesn't appear any more with 544f6a3 |
||
| "push32withoutByte_d0g0v0_Constantinople" | ||
| ] | ||
| }, | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stSystemOperationsTest", | ||
|
There was a problem hiding this comment. This can be removed as well with 544f6a3 |
||
| "subtests": [ | ||
| "doubleSelfdestructTest_d0g0v0_Constantinople", | ||
| "doubleSelfdestructTest2_d0g0v0_Constantinople" | ||
| ] | ||
| } | ||
|
|
||
|
|
||
| ], | ||
| "state": | ||
| [ | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stCreateTest", | ||
| "subtests": { | ||
| "CreateOOGafterInitCodeReturndata2": { | ||
| "subnumbers": ["2"], | ||
| "chain": "Constantinople (test)" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stEIP150Specific", | ||
| "subtests": { | ||
| "NewGasPriceForCodes": { | ||
| "subnumbers": ["1"], | ||
| "chain": "Constantinople (test)" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stInitCodeTest", | ||
| "subtests": { | ||
| "OutOfGasContractCreation": { | ||
| "subnumbers": ["4"], | ||
| "chain": "Constantinople (test)" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stPreCompiledContracts", | ||
| "subtests": { | ||
| "modexp": { | ||
| "subnumbers": ["*"], | ||
| "chain": "Constantinople (test)" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stRevertTest", | ||
| "subtests": { | ||
| "LoopCallsDepthThenRevert3": { | ||
| "subnumbers": ["1"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "RevertOpcodeCreate": { | ||
| "subnumbers": ["1"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "RevertSubCallStorageOOG2": { | ||
| "subnumbers": ["1","3"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "RevertDepthCreateOOG": { | ||
| "subnumbers": ["3","4"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "RevertOpcodeMultipleSubCalls": { | ||
| "subnumbers": ["*"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "RevertOpcodeDirectCall": { | ||
| "subnumbers": ["1","2"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "LoopCallsDepthThenRevert2": { | ||
| "subnumbers": ["1"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "RevertDepth2": { | ||
| "subnumbers": ["1"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "RevertRemoteSubCallStorageOOG2": { | ||
| "subnumbers": ["1","2"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "RevertDepthCreateAddressCollision": { | ||
| "subnumbers": ["3","4"], | ||
| "chain": "Constantinople (test)" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stStaticCall", | ||
|
There was a problem hiding this comment. Those are passing except |
||
| "subtests": { | ||
| "static_callCreate": { | ||
| "subnumbers": ["2"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "static_CheckOpcodes4": { | ||
| "subnumbers": ["3"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "static_CheckOpcodes3": { | ||
| "subnumbers": ["5","6","7","8"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "static_RevertDepth2": { | ||
| "subnumbers": ["1"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "static_callBasic": { | ||
| "subnumbers": ["1","2"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "static_CheckOpcodes2": { | ||
| "subnumbers": ["5","6","7","8"], | ||
| "chain": "Constantinople (test)" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "reference": 9568, | ||
| "failing": "stZeroKnowledge", | ||
| "subtests": { | ||
| "pointAddTrunc": { | ||
|
There was a problem hiding this comment. Looks like those are passing except There was a problem hiding this comment. There is something not so good with the way the test are currently running : having a first failure is hiding other tests failure (it reports only one failure but if I skip it, it shows the other ones). So the other test in this branch are still failing for me. There was a problem hiding this comment. I think those one are all actually passing except There was a problem hiding this comment. Not passing :( , there is something bad with our current code : if you run the test without skipping anything it fails on only one test, but as soon as you skip it, it reveals others failure. There was a problem hiding this comment. Got it! Can you also cherry-pick 16f661a? Our previous definition of There was a problem hiding this comment. Indeed, it does reduce the number of failing zk tests. Many still don't pass, but it is due to ethereum/tests#512 (with 1283 disabled everything is fine). |
||
| "subnumbers": ["*"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "pointAdd": { | ||
|
There was a problem hiding this comment. This one is indeed |
||
| "subnumbers": ["*"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "pointMulAdd": { | ||
| "subnumbers": ["*"], | ||
| "chain": "Constantinople (test)" | ||
| }, | ||
| "pointMulAdd2": { | ||
| "subnumbers": ["*"], | ||
| "chain": "Constantinople (test)" | ||
| } | ||
|
|
||
| } | ||
| } | ||
|
|
||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Copyright 2015-2018 Parity Technologies (UK) Ltd. | ||
| // This file is part of Parity. | ||
|
|
||
| // Parity is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
|
|
||
| // Parity is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
|
|
||
| // You should have received a copy of the GNU General Public License | ||
| // along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| //! State tests to skip. | ||
|
|
||
| use ethjson; | ||
|
|
||
| lazy_static!{ | ||
|
|
||
|
|
||
| pub static ref SKIP_TEST_STATE: ethjson::test::SkipStates = { | ||
| let skip_data = include_bytes!("../../res/ethereum/tests-issues/currents.json"); | ||
| ethjson::test::SkipStates::load(&skip_data[..]).expect("No invalid json allowed") | ||
| }; | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this file to use tabs for indentation.