Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeneralStateTests/stZeroKnowledge/pointAdd not taking account of EIP-1283 in Constantinople #512

Closed
sorpaas opened this issue Sep 18, 2018 · 2 comments
Closed

GeneralStateTests/stZeroKnowledge/pointAdd not taking account of EIP-1283 in Constantinople #512

sorpaas opened this issue Sep 18, 2018 · 2 comments

Comments

@sorpaas
Copy link

sorpaas commented Sep 18, 2018

For example, in test index 5, two SSTORE are present to set storage 0x0 twice. However, the hash expected for Byzantium and Constantinople are the same.
@sorpaas sorpaas mentioned this issue Sep 18, 2018
Merged
@cheme cheme mentioned this issue Sep 19, 2018
Closed
17 tasks
@MattMSumner MattMSumner mentioned this issue Sep 25, 2018
Merged
@winsvega
Copy link
Collaborator

The tets has recently been updated for Constantinople. Issue should be gone by now.
Do you still have any tests failing?

@cheme
Copy link

cheme commented Oct 11, 2018

No the tests are not failing anymore 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cheme @winsvega @sorpaas