Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Run cargo fix on a few of the worst offenders #10854

Merged
merged 8 commits into from
Jul 9, 2019
Merged

Run cargo fix on a few of the worst offenders #10854

merged 8 commits into from
Jul 9, 2019

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented Jul 6, 2019

The amount of warnings is getting out of hand. This PR is the result of running cargo fix on some of the worst offenders. I tried to avoid crates where I know people are working to minimize the impact, but there'll be more of these.

@dvdplm dvdplm self-assigned this Jul 6, 2019
@dvdplm dvdplm added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Jul 6, 2019
@ordian ordian added this to the 2.7 milestone Jul 6, 2019
@dvdplm dvdplm requested review from debris and ordian July 8, 2019 17:28
ordian
ordian approved these changes Jul 8, 2019
View reviewed changes
Copy link
Collaborator

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Box<dyn Lgtm>

@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 8, 2019
@seunlanlege seunlanlege merged commit f53c3e5 into master Jul 9, 2019
@seunlanlege seunlanlege deleted the dp/chore/cargo-fix-a-few-crates branch July 9, 2019 08:04
ordian added a commit that referenced this pull request Jul 9, 2019
@ordian
Merge branch 'master' into MaybeUninit
222d1b8 
* master:
  Run cargo fix on a few of the worst offenders (#10854)
  removed redundant fork choice abstraction (#10849)
  Extract state-db from ethcore (#10858)
  Fix fork choice (#10837)
  Move more code into state-account (#10840)
  Remove compiler warning (#10865)
  [ethash] use static_assertions crate (#10860)
dvdplm added a commit that referenced this pull request Jul 9, 2019
@dvdplm
Merge branch 'master' into dp/chore/extract-verification
2c86e2b 
* master:
  Run cargo fix on a few of the worst offenders (#10854)
  removed redundant fork choice abstraction (#10849)
  Extract state-db from ethcore (#10858)
  Fix fork choice (#10837)
  Move more code into state-account (#10840)
  Remove compiler warning (#10865)
  [ethash] use static_assertions crate (#10860)
dvdplm added a commit that referenced this pull request Jul 11, 2019
@dvdplm
Merge branch 'master' into dp/chore/extract-state-followup
9cb241d 
* master:
  Docker images renaming (#10863)
  Move the substate module into ethcore/executive (#10867)
  Run cargo fix on a few of the worst offenders (#10854)
  removed redundant fork choice abstraction (#10849)
  Extract state-db from ethcore (#10858)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@seunlanlege seunlanlege seunlanlege approved these changes

@debris debris Awaiting requested review from debris

Assignees

@dvdplm dvdplm

Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@dvdplm @ordian @seunlanlege