This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
removed redundant fork choice abstraction #10849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
debris
commented
Jul 5, 2019
| @@ -501,32 +501,24 @@ impl Importer { | |||
| let traces = block.traces.drain(); | |||
| let best_hash = chain.best_block_hash(); | |||
|
|
|||
| let new = ExtendedHeader { | |||
| header: header.clone(), | |||
debris
commented
Jul 5, 2019
| let header = chain.block_header_data(&best_hash) | ||
| .expect("Best block is in the database; qed") | ||
| .decode() | ||
| .expect("Stored block header is valid RLP; qed"); |
There was a problem hiding this comment.
redundant database query and block header decoding
dvdplm
reviewed
Jul 5, 2019
dvdplm
approved these changes
Jul 8, 2019
ordian
approved these changes
Jul 8, 2019
ordian
added
A8-looksgood 🦄
sorpaas
approved these changes
Jul 9, 2019
ordian
added a commit
that referenced
this pull request
Jul 9, 2019
* master: Run cargo fix on a few of the worst offenders (#10854) removed redundant fork choice abstraction (#10849) Extract state-db from ethcore (#10858) Fix fork choice (#10837) Move more code into state-account (#10840) Remove compiler warning (#10865) [ethash] use static_assertions crate (#10860)
dvdplm
added a commit
that referenced
this pull request
Jul 9, 2019
* master: Run cargo fix on a few of the worst offenders (#10854) removed redundant fork choice abstraction (#10849) Extract state-db from ethcore (#10858) Fix fork choice (#10837) Move more code into state-account (#10840) Remove compiler warning (#10865) [ethash] use static_assertions crate (#10860)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fork_choice is always based on total difficulty, so it does not need to be abstracted