Skip to content

Fixes #461 restore openemr command path fix #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

Fixes #461 restore openemr command path fix #462

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fb3703
Fixes #461 restore openemr command path fix
adunsulag Jul 2, 2025
40740ce
Add exit to cd command in case cd fails
adunsulag Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker/openemr/flex/utilities/devtoolsLibrary.source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ backupOpenemr() {

# parameter 1 is identifier
restoreOpenemr() (
cd /snapshots || exit
tar -C /snapshots -xzf "${1}.tgz"
Copy link
Contributor

@kojiromike kojiromike Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what -C is supposed to do. What did I miss?

Copy link
Contributor

@kojiromike kojiromike Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw your comment in the ticket. I thought there was a reason why doing cd for the entirety of the subshell was not desirable, but I can't recall now. Anyway, let's try it.

Copy link
Member Author

@adunsulag adunsulag Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I wondered why the cd was removed and thought there had to be a reason. The -C only works for the export of tar from what the man page and my testing showed. The file input argument ignores the -C which is annoying.

# need to empty the database before the restore database import
mariadb-dump --skip-ssl -u "${CUSTOM_ROOT_USER}" --password="${MYSQL_ROOT_PASS}" -h "${MYSQL_HOST}" -P "${CUSTOM_PORT}" --add-drop-table --no-data "${CUSTOM_DATABASE}" |
Expand Down
Loading