Fixes #461 restore openemr command path fix #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds back in the cd /snapshots to the restore command so that the tar extraction command successfully works.
Fixing shellcheck warnings and adding in exit
kojiromike
reviewed
Jul 2, 2025
| # parameter 1 is identifier | ||
| restoreOpenemr() ( | ||
| cd /snapshots || exit | ||
| tar -C /snapshots -xzf "${1}.tgz" |
Contributor
There was a problem hiding this comment.
This is what -C is supposed to do. What did I miss?
Contributor
There was a problem hiding this comment.
Just saw your comment in the ticket. I thought there was a reason why doing cd for the entirety of the subshell was not desirable, but I can't recall now. Anyway, let's try it.
Member
Author
There was a problem hiding this comment.
Yea I wondered why the cd was removed and thought there had to be a reason. The -C only works for the export of tar from what the man page and my testing showed. The file input argument ignores the -C which is annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back in the cd /snapshots to the restore command so that the tar extraction command successfully works.
Fixes #461