-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jwt-cpp: add v0.6.0 #630
Closed
Closed
jwt-cpp: add v0.6.0 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request created via mailing list, see [meta-oe] jwt-cpp: add v0.6.0. Closing. |
quaresmajose
pushed a commit
to quaresmajose/meta-openembedded
that referenced
this pull request
Dec 19, 2022
Changelog: ========== This release has EDE support, for extended EDNS error reporting, it fixes unsupported ZONEMD algorithms to load, and has more bug fixes. The EDE errors can be turned on by 'ede: yes', it is default disabled. Validation errors and other errors are then reported. If you also want stale answers for expired responses to have an error code, the option 'ede-serve-expired: yes' can be used. Features - Merge PR openembedded#604: Add basic support for EDE (RFC8914). Bug Fixes - Fix openembedded#412: cache invalidation issue with CNAME+A. - Fix that TCP interface does not use TLS when TLS is also configured. - Fix openembedded#624: Unable to stop Unbound in Windows console (does not respond to CTRL+C command). - Fix openembedded#618: enabling interface-automatic disables DNS-over-TLS. Adds the option to list interface-automatic-ports. - Remove debug info from openembedded#618 fix. - Fix openembedded#628: A rpz-passthru action is not ending RPZ zone processing. - Fix for openembedded#628: fix rpz-passthru for qname trigger by localzone type. - Fix that address not available is squelched from the logs for udp connect failures. It is visible on verbosity 4 and more. - Merge openembedded#631 from mollyim: Replace OpenSSL's ERR_PACK with ERR_GET_REASON. - Fix to detect that no IPv6 support means that IPv6 addresses are useless for delegation point lookups. - update Makefile dependencies. - Fix check interface existence for support detection in remote lookup. - Fix openembedded#633: Document unix domain socket support for unbound-control. - Fix for openembedded#633: updated fix with new text. - Fix edns client subnet to add the option based on the option list, so that it is not state dependent, after the state fix of openembedded#605 for double EDNS options. - Fix for edns client subnet option add fix in removal code, from review. - Fix openembedded#630: Unify the RPZ log messages. - Merge openembedded#623 from rex4539: Fix typos. - Fix pythonmod for change in iter_dp_is_useless function prototype. - Fix compile warnings for printf ll format on mingw compile. - Merge PR openembedded#632 from scottrw93: Match cnames in ipset. - Various fixes for openembedded#632: variable initialisation, convert the qinfo to str once, accept trailing dot in the local-zone ipset option. - Fix openembedded#637: Integer Overflow in sldns_str2period function. - Fix for openembedded#637: fix integer overflow checks in sldns_str2period. - Fix configure for python to use sysutils, because distutils is deprecated. It uses sysutils when available, distutils otherwise. - Merge openembedded#644: Make 'install-lib' make target install the pkg-config file. - Fix to ensure uniform handling of spaces and tabs when parsing RRs. - Fix to describe auth-zone and other configuration at the local-zone configuration option, to allow for more broadly view of the options. - Merge PR openembedded#648 from eaglegai: fix -q doesn't work when use with 'unbound-control stats_shm'. - Fix openembedded#651: [FR] Better logging for refused queries. - Fix spelling error in comment in sldns_str2wire_svcparam_key_lookup. - Fix zonemd check to allow unsupported algorithms to load. If there are only unsupported algorithms, or unsupported schemes, and no failed or successful other ZONEMD records, or malformed or bad ZONEMD records, the unsupported records allow the zone load. - Fix zonemd unsupported algo check. - Fix zonemd unsupported algo check reason to not copy to next record, and check for success for debug printout. - Fix zonemd unsupported algo check to print unsupported reason before zeroing it. - Fix zonemd unsupported algo check to set reason to NULL before the check routine, but after malformed checks, to get the correct NULL output when the digest matches. - Fix openembedded#670: SERVFAIL problems with unbound 1.15.0 running on OpenBSD 7.1. - Fix Python build in non-source directory; based on patch by Michael Tokarev. - Fix openembedded#673: DNS over TLS: error: SSL_handshake syscall: No route to host. - Merge openembedded#677: Allow using system certificates not only on Windows, from pemensik. - For openembedded#677: Added tls-system-cert to config parser and documentation. - Fix openembedded#417: prefetch and ECS causing cache corruption when used together. - Fix openembedded#678: [FR] modify behaviour of unbound-control rpz_enable zone, by updating unbound-control's documentation. - Fix typos in config_set_option for the 'num-threads' and 'ede-serve-expired' options. - Fix to silence test for ede error output to the console from the test setup script. - Fix ede test to not use default pidfile, and use local interface. - Fix some lint type warnings. - Fix openembedded#684: [FTBS] configure script error with libmnl on openSUSE 15.3 (and possibly other distributions) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Dec 20, 2022
Changelog: ========== Fix comments generation for submessages (openembedded#788) Fix handling of spaces in arguments passed through protoc (openembedded#810) Fix problems with multiple files and mangle_names option (openembedded#783, openembedded#820) Fix generator error when using M_STRIP_PACKAGE without package name (openembedded#795) Fix compilation error with fixed size array and FT_POINTER (openembedded#630) Fix wrong format in Python Poetry project file (openembedded#811) Fix unnecessary generator message when using --quiet (openembedded#831) Fix enum_to_string with C++ (openembedded#838) Fix /* */ inside .proto file comment Workaround python-protobuf version issues (openembedded#787) Safeguard substraction in pb_read() with custom streams (openembedded#697) Always include pb_release() as function, instead of macro. (openembedded#802) Allow using = instead of : with generator option -s Allow specifying include format without special characters (openembedded#810) Allow including headers from inside of extern C (openembedded#814) Add option NANOPB_PB2_TEMP_DIR to store nanopb_pb2.py in a temporary dir (openembedded#601) Add compile-time error message for when PB_FIELD_32BIT is needed (openembedded#680, openembedded#827) Add --c-style command line option for naming style (openembedded#199, openembedded#533, openembedded#791) Add --protoc-opt to nanopb_generator.py (openembedded#628) Add ENUMTYPE convenience macros (openembedded#803) Add Bazel build rules (openembedded#360, openembedded#500) Generator: keep order of messages when possible Test case improvements (openembedded#792) PlatformIO build rule improvements (openembedded#808, openembedded#809, openembedded#819, openembedded#834, openembedded#839, openembedded#840) CMake build rule improvements (openembedded#822) CMakeLists: use protoc wrapper script by default (openembedded#769) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Dec 20, 2022
Changelog: ========== Fix comments generation for submessages (openembedded#788) Fix handling of spaces in arguments passed through protoc (openembedded#810) Fix problems with multiple files and mangle_names option (openembedded#783, openembedded#820) Fix generator error when using M_STRIP_PACKAGE without package name (openembedded#795) Fix compilation error with fixed size array and FT_POINTER (openembedded#630) Fix wrong format in Python Poetry project file (openembedded#811) Fix unnecessary generator message when using --quiet (openembedded#831) Fix enum_to_string with C++ (openembedded#838) Fix /* */ inside .proto file comment Workaround python-protobuf version issues (openembedded#787) Safeguard substraction in pb_read() with custom streams (openembedded#697) Always include pb_release() as function, instead of macro. (openembedded#802) Allow using = instead of : with generator option -s Allow specifying include format without special characters (openembedded#810) Allow including headers from inside of extern C (openembedded#814) Add option NANOPB_PB2_TEMP_DIR to store nanopb_pb2.py in a temporary dir (openembedded#601) Add compile-time error message for when PB_FIELD_32BIT is needed (openembedded#680, openembedded#827) Add --c-style command line option for naming style (openembedded#199, openembedded#533, openembedded#791) Add --protoc-opt to nanopb_generator.py (openembedded#628) Add ENUMTYPE convenience macros (openembedded#803) Add Bazel build rules (openembedded#360, openembedded#500) Generator: keep order of messages when possible Test case improvements (openembedded#792) PlatformIO build rule improvements (openembedded#808, openembedded#809, openembedded#819, openembedded#834, openembedded#839, openembedded#840) CMake build rule improvements (openembedded#822) CMakeLists: use protoc wrapper script by default (openembedded#769) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Dec 21, 2022
Changelog: ========== Fix comments generation for submessages (openembedded#788) Fix handling of spaces in arguments passed through protoc (openembedded#810) Fix problems with multiple files and mangle_names option (openembedded#783, openembedded#820) Fix generator error when using M_STRIP_PACKAGE without package name (openembedded#795) Fix compilation error with fixed size array and FT_POINTER (openembedded#630) Fix wrong format in Python Poetry project file (openembedded#811) Fix unnecessary generator message when using --quiet (openembedded#831) Fix enum_to_string with C++ (openembedded#838) Fix /* */ inside .proto file comment Workaround python-protobuf version issues (openembedded#787) Safeguard substraction in pb_read() with custom streams (openembedded#697) Always include pb_release() as function, instead of macro. (openembedded#802) Allow using = instead of : with generator option -s Allow specifying include format without special characters (openembedded#810) Allow including headers from inside of extern C (openembedded#814) Add option NANOPB_PB2_TEMP_DIR to store nanopb_pb2.py in a temporary dir (openembedded#601) Add compile-time error message for when PB_FIELD_32BIT is needed (openembedded#680, openembedded#827) Add --c-style command line option for naming style (openembedded#199, openembedded#533, openembedded#791) Add --protoc-opt to nanopb_generator.py (openembedded#628) Add ENUMTYPE convenience macros (openembedded#803) Add Bazel build rules (openembedded#360, openembedded#500) Generator: keep order of messages when possible Test case improvements (openembedded#792) PlatformIO build rule improvements (openembedded#808, openembedded#809, openembedded#819, openembedded#834, openembedded#839, openembedded#840) CMake build rule improvements (openembedded#822) CMakeLists: use protoc wrapper script by default (openembedded#769) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead
pushed a commit
that referenced
this pull request
Dec 23, 2022
Changelog: ========== Fix comments generation for submessages (#788) Fix handling of spaces in arguments passed through protoc (#810) Fix problems with multiple files and mangle_names option (#783, #820) Fix generator error when using M_STRIP_PACKAGE without package name (#795) Fix compilation error with fixed size array and FT_POINTER (#630) Fix wrong format in Python Poetry project file (#811) Fix unnecessary generator message when using --quiet (#831) Fix enum_to_string with C++ (#838) Fix /* */ inside .proto file comment Workaround python-protobuf version issues (#787) Safeguard substraction in pb_read() with custom streams (#697) Always include pb_release() as function, instead of macro. (#802) Allow using = instead of : with generator option -s Allow specifying include format without special characters (#810) Allow including headers from inside of extern C (#814) Add option NANOPB_PB2_TEMP_DIR to store nanopb_pb2.py in a temporary dir (#601) Add compile-time error message for when PB_FIELD_32BIT is needed (#680, #827) Add --c-style command line option for naming style (#199, #533, #791) Add --protoc-opt to nanopb_generator.py (#628) Add ENUMTYPE convenience macros (#803) Add Bazel build rules (#360, #500) Generator: keep order of messages when possible Test case improvements (#792) PlatformIO build rule improvements (#808, #809, #819, #834, #839, #840) CMake build rule improvements (#822) CMakeLists: use protoc wrapper script by default (#769) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Dec 19, 2023
Use PACKAGE_BEFORE_PN which is designed to introduce packages before the final greedy ${PN}. Changes 1.24.0: Brad House (28): Nameserver parsing: replace another hand-written parser (openembedded#643) clang-format SonarCloud: silence bogus reported error ares_init_options() with invalid options values should unset the option Enable system extensions try to move AC_USE_SYSTEM_EXTENSIONS ares__round_up_pow2() work around bogus warning silence openwatcom warning due to qcache_max_ttl being unsigned Support ipv6 link-local servers and %iface syntax (openembedded#646) Windows UBSAN tests (openembedded#649) increment failures on timeout (openembedded#651) SonarCloud: make const enhance timeout test case enhance timeout test case to make sure it will re-use a previously downed server Rewrite sortlist hand parser for memory safety and bugs (openembedded#653) Clean up some Windows-only warnings (openembedded#654) clang-format and fix one warning remove redundant cast use IF_NAMESIZE instead of IFNAMSIZ to avoid warning Use external GoogleTest instead of bundling it (openembedded#655) remove dead code: bitncmp remove dead code: ares_iphlpapi.h Coverity: fix allocation size as reported in new code tag some functions as deprecated in docs reference alternative to ares_getsock() in docs 1.24.0 release prep (openembedded#657) rand: allow fallback from OS (openembedded#661) ares_cancel() could trigger callback with wrong response code (openembedded#663) Changes 1.23.0: Brad House (21): Query Cache support (openembedded#625) ares_set_servers_*() should allow an empty server list Fix Windows UWP (Store) building and add to CI/CD (openembedded#627) clang-format cleanup some Windows warnings in test fix additional windows test warnings CMake: CXXFLAGS environment wasn't being read because C++ compiler was enabled after settings warnings. now that warnings are enabled on test cases, clear a bunch of warnings fix test case regression due to missing parens SonarCloud: fix minor codesmells more precise timeout calculation (openembedded#633) environment is meant as an override for sysconfig Fix MacOS version test Basic Thread Safety (openembedded#636) fix ares_threadsafety() prototype ares_init_options with ARES_OPT_UDP_PORT wrong byte order fix doc typo remove a simply clang-format add missing manpage to distribution list 1.23.0 release prep (openembedded#641) Christian Clauss (2): INSTALL.md: Fix typo (openembedded#630) Fix typos discovered by codespell (openembedded#634) Daniel Stenberg (1): CI: codespell Ignat (1): Support attempts and timeout options from resolv.conf (openembedded#632) petrvh (1): ares_getaddrinfo(): do not use search domains if ARES_FLAG_NOSEARCH is set (openembedded#638) Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead
pushed a commit
that referenced
this pull request
Dec 20, 2023
Use PACKAGE_BEFORE_PN which is designed to introduce packages before the final greedy ${PN}. Changes 1.24.0: Brad House (28): Nameserver parsing: replace another hand-written parser (#643) clang-format SonarCloud: silence bogus reported error ares_init_options() with invalid options values should unset the option Enable system extensions try to move AC_USE_SYSTEM_EXTENSIONS ares__round_up_pow2() work around bogus warning silence openwatcom warning due to qcache_max_ttl being unsigned Support ipv6 link-local servers and %iface syntax (#646) Windows UBSAN tests (#649) increment failures on timeout (#651) SonarCloud: make const enhance timeout test case enhance timeout test case to make sure it will re-use a previously downed server Rewrite sortlist hand parser for memory safety and bugs (#653) Clean up some Windows-only warnings (#654) clang-format and fix one warning remove redundant cast use IF_NAMESIZE instead of IFNAMSIZ to avoid warning Use external GoogleTest instead of bundling it (#655) remove dead code: bitncmp remove dead code: ares_iphlpapi.h Coverity: fix allocation size as reported in new code tag some functions as deprecated in docs reference alternative to ares_getsock() in docs 1.24.0 release prep (#657) rand: allow fallback from OS (#661) ares_cancel() could trigger callback with wrong response code (#663) Changes 1.23.0: Brad House (21): Query Cache support (#625) ares_set_servers_*() should allow an empty server list Fix Windows UWP (Store) building and add to CI/CD (#627) clang-format cleanup some Windows warnings in test fix additional windows test warnings CMake: CXXFLAGS environment wasn't being read because C++ compiler was enabled after settings warnings. now that warnings are enabled on test cases, clear a bunch of warnings fix test case regression due to missing parens SonarCloud: fix minor codesmells more precise timeout calculation (#633) environment is meant as an override for sysconfig Fix MacOS version test Basic Thread Safety (#636) fix ares_threadsafety() prototype ares_init_options with ARES_OPT_UDP_PORT wrong byte order fix doc typo remove a simply clang-format add missing manpage to distribution list 1.23.0 release prep (#641) Christian Clauss (2): INSTALL.md: Fix typo (#630) Fix typos discovered by codespell (#634) Daniel Stenberg (1): CI: codespell Ignat (1): Support attempts and timeout options from resolv.conf (#632) petrvh (1): ares_getaddrinfo(): do not use search domains if ARES_FLAG_NOSEARCH is set (#638) Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Dec 16, 2024
- Refresh patches Version 1.82.1 -------------- - Closed bugs and merge requests: * gnome-shell crash when switching user after upgrade from Fedora 40 to Fedora 41 [openembedded#647, !955, Philip Chimento] Version 1.82.0 -------------- - Closed bugs and merge requests: * installed tests are failing because they can't load internal typelibs from parent directory [openembedded#639, !953, Simon McVittie] * GIMarshalling test has 3 failures with 1.81.90 on i686 [openembedded#642, !954, Philip Chimento] Version 1.81.90 --------------- - Closed bugs and merge requests: * callbacks: fix sweeping check for incremental GC [!859, !950, Evan Welsh, Gary Li] * GJS doesn't handle query parameters in imports [openembedded#618, !944, Gary Li] * Integrate gobject-introspection-tests as submodule [!946, Philip Chimento] * module: Include full module specifier in import.meta.url [!947, Philip Chimento] * doap: Remove invalid maintainer entry [!948, Sophie Herold] * installed tests have the wrong libexecdir [openembedded#636, !949, Jeremy Bicha] * Inheriting final class crashes GJS [openembedded#640, !951, Gary Li] * Various maintenance [!952, Philip Chimento] Version 1.81.2 -------------- - New JavaScript features! This version of GJS is based on SpiderMonkey 128, an upgrade from the previous ESR (Extended Support Release) of SpiderMonkey 115. Here are the highlights of the new JavaScript features. For more information, look them up on MDN or devdocs.io. * New APIs + The new `Object.groupBy()` and `Map.groupBy()` static methods group the elements of an iterable according to the return value of a key function. + The new `Promise.withResolvers()` static method returns a Promise as well as its resolve and reject functions, shorthand for a common pattern used when promisifying event-based APIs. + Strings have gained the `isWellFormed()` and `toWellFormed()` methods which help when interoperating with strings that may have unpaired Unicode surrogates. This usually does not come up in the GNOME platform. + ArrayBuffers have gained the `transfer()` and `transferToFixedLength()` methods, which transfer ownership of a data buffer to a new ArrayBuffer object, without copying it, and invalidating ("detaching") any existing references to the buffer. There is also a new property, `detached`, which allows checking whether an ArrayBuffer is in the detached state. + The new `Intl.Segmenter` class allows splitting a string into graphemes, words, or sentences, in a locale-aware way. + `Intl.NumberFormat` has gained `formatRange()` and `formatRangeToParts()` methods, which allow formatting number ranges, like "3–5". + `Intl.PluralRules` has gained a `selectRange()` method, which allows selecting the proper plural form based on a range of numbers, like "30–50 feral hogs". * New behaviour + The `Intl.NumberFormat` and `Intl.PluralRules` constructors support new options: `roundingIncrement`, `roundingMode`, `roundingPriority`, and `trailingZeroDisplay`. + The `Intl.NumberFormat` constructor also supports the new option `useGrouping`. * Backwards-incompatible changes + The behaviour of `Date.parse()` has been changed to be more consistent with other JavaScript engines. (But don't use `Date.parse()`.) - Closed bugs and merge requests: * Invalid search paths cause failed assertions when printing imports.gi [openembedded#629, !935, Gary Li] * SpiderMonkey 128 [openembedded#630, !936, !945, Philip Chimento] * Pretty-printing byte array in gjs-console throws a type conversion error [openembedded#434, !937, Gary Li] * js: Add gjs_debug_callable() debug function [!940, Philip Chimento] * build: Build Cairo from subproject if not found [!941, Philip Chimento] * Bump CI image to Fedora 40 [!942, Philip Chimento] * CI tools updates [!943, Philip Chimento] Version 1.81.1 -------------- - Breaking change: When creating a GObject with the `new` operator, the constructor takes a single argument consisting of a property bag with GObject construct properties and their values. This was often confused with the `new` static method that may take arguments that are not interpreted as property bags. For example, Gio.FileIcon was one of the many affected APIs: new Gio.FileIcon({file: myFile}) vs Gio.FileIcon.new(myFile) Confusion between the two often lead to bug reports when confusing these two and calling `new Gio.FileIcon(myFile)` - the constructor would look for a nonexistent `file` property on `myFile`, causing an improperly initialized object. This is now no longer allowed. The argument to `new Gio.FileIcon(...)` must be a plain JS object, not a GObject. It's possible that existing code legitimately used a GObject here. If your code does this and a quick migration is impractical, please get in touch and we will revert this change before 1.82.0 in favour of a longer deprecation period. - The `get_data()`, `get_qdata()`, `set_data()`, `steal_data()`, `steal_qdata()`, `ref()`, `unref()`, `ref_sink()`, and `force_floating()` methods of GObject now throw if called. These methods never worked, but sometimes they would silently appear to succeed, then cause crashes or memory leaks later. If you were trying to use the `get_data()` family of methods, just set a JS property instead. If you were trying to modify the refcount of a GObject in JS, instead set the object as the value of a JS property on some other object. - Closed bugs and merge requests: * doc: Document how to get a stack trace [!864, Sonny Piers] * TextDecoder should accept GBytes [openembedded#587, !903, Sriyansh Shivam] * Possible use-after-free with GLib.Regex.match/GLib.MatchInfo [openembedded#589, !920, Philip Chimento] * method `get_line` of `Pango.Layout` doesn't work. [openembedded#547, !921, Philip Chimento] * Block calls to g_object_get_data and friends [openembedded#423, !922, Philip Chimento] * Crash when calling Pango.Layout.get_pixel_size() with a badly init:ed Pango.Layout [openembedded#580, !923, Philip Chimento] * doc: avoid reference to Gio.UnixInputStream [!925, Andy Holmes] * Add a CI check for config.h, and some other useful checks [openembedded#447, !926, Philip Chimento] * Incorrect UnixOutputStream warning [openembedded#610, !928, Philip Chimento] * Various maintenance [!929, !931, Philip Chimento] * Docs: Various markdown fixes [!930, Frank Dana] * Some build fixes for the main (and gnome-46) branches for Visual Studio [!932, Chun-wei Fan] * GJS doesn't log undefined values [openembedded#621, !933, Gary Li] * property objects are printed as empty js objects [openembedded#622, !934, Gary Li] Signed-off-by: Markus Volk <f_l_k@t-online.de> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.