php: host config leakage of HAS_VALGRIND #94

abaumfalk · 2018-09-19T12:21:50Z

In the build process of php7.2.7 there seems to be a host configuration leakage to the target build.
I have installed valgrind on my build host and the php target build fails with:

.../build/tmp/work/core2-32-poky-linux/php/7.2.7-r0/php-7.2.7/sapi/cgi/cgi_main.c:100:11: fatal error: valgrind/callgrind.h: No such file or directory
| # include "valgrind/callgrind.h"
| ^~~~~~~~~~~~~~~~~~~~~~
| compilation terminated.
| make: *** [sapi/cgi/cgi_main.lo] Error 1
| make: *** Waiting for unfinished jobs....
| ERROR: oe_runmake failed
| WARNING: .../build/tmp/work/core2-32-poky-linux/php/7.2.7-r0/temp/run.do_compile.7658:1 exit 1 from 'exit 1'
| ERROR: Function failed: do_compile (log file is located at .../build/tmp/work/core2-32-poky-linux/php/7.2.7-r0/temp/log.do_compile.7658)
ERROR: Task (.../build/../meta-openembedded/meta-oe/recipes-devtools/php/php_7.2.7.bb:do_compile) failed with exit code '1'

When I remove valgrind from my host system, the build runs fine.

Checking the php source code I found that HAS_VALGRIND seems to be defined when the build fails, although there is no valgrind installed on the host.

I have seen this problem on the most recent sumo branch of meta-openembedded.

If I can add more information, please let me know!

fmhess · 2018-11-19T01:51:40Z

I have hit this same problem building angstrom sumo. Anyone know how to manually tell php config not to use valgrind?

fmhess · 2018-11-19T01:56:06Z

found more info on the php problem here:

http://patchwork.ozlabs.org/patch/872168/

kraj · 2018-12-22T00:36:05Z

This should be fixed by 840850e
if not reopen

This includes the following changes: 8d73296 test message update 31f752f tests reorganization c9604f7 more updates in credits and news bbef3ab add brian to credits and update news. 6d9f4c3 whitespace fixes 3a26b75 Merge branch 'master' of https://github.com/rpodgorny/unionfs-fuse 3b46d86 whitespace formatting 9a1765a Merge pull request openembedded#93 from briankendall/mac-fixes f1bd82a Merge pull request openembedded#94 from lightmare/man-page-typos 34f4840 man page wording 8e145ad man page formatting 2249ae9 fix some man page typos and missing commas f3fccaf Fix tests in macOS 29d8b6c Fix error code -50 when copying files using Finder in macOS 5f1431a Merge pull request openembedded#90 from h3xx/fix-mandir-path 04ed9a2 Use standard variable for man page install path 2ac5726 updated readme to explain where the cache is 24b46b6 add atha to credits eaf8397 Fix compilation on macOS b663b12 annotate ioctl call correctly as DBG() c8d23a9 whitespace formatting de61d85 Merge branch 'therealfun-master' df79b8e minor test improvements d8d20c2 Implement access() for "cow,relaxed_permissions" use case b97ff88 typo fix 75a367c formatting 7e9e708 restore errno in dbg macro 039ba92 more useful tests output b5a7392 add julien to credits fa2ec03 Merge branch 'bplaa-yai-master' 1d91cfe Merge branch 'master' of https://github.com/bplaa-yai/unionfs-fuse into bplaa-yai-master b48fa6a fix travis script 6947e79 more tests 341dfc8 formatting b2d8426 whitespace formatting c393877 prepare mknod test 99a529c typo fix 5df6aec add test case for mkdir and sync (not working) f15bc13 add tests to makefile 8ef0b14 more tests e0e8233 add coverage files to gitignore and clean it up a bit 0460915 whitespace formatting f0acead whitespace formatting 80be111 make unionfs_oper accessible outside of its compilation unit a016d2d make add_branch and parse_branches accessible outside of their compilation unit 1df24c6 add rules for static and shared libraries, update objects list d4e62eb separate main logic from fuse ops handlers Also remove patch already in version. Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>

This includes the following changes: 8d73296 test message update 31f752f tests reorganization c9604f7 more updates in credits and news bbef3ab add brian to credits and update news. 6d9f4c3 whitespace fixes 3a26b75 Merge branch 'master' of https://github.com/rpodgorny/unionfs-fuse 3b46d86 whitespace formatting 9a1765a Merge pull request openembedded#93 from briankendall/mac-fixes f1bd82a Merge pull request openembedded#94 from lightmare/man-page-typos 34f4840 man page wording 8e145ad man page formatting 2249ae9 fix some man page typos and missing commas f3fccaf Fix tests in macOS 29d8b6c Fix error code -50 when copying files using Finder in macOS 5f1431a Merge pull request openembedded#90 from h3xx/fix-mandir-path 04ed9a2 Use standard variable for man page install path 2ac5726 updated readme to explain where the cache is 24b46b6 add atha to credits eaf8397 Fix compilation on macOS b663b12 annotate ioctl call correctly as DBG() c8d23a9 whitespace formatting de61d85 Merge branch 'therealfun-master' df79b8e minor test improvements d8d20c2 Implement access() for "cow,relaxed_permissions" use case b97ff88 typo fix 75a367c formatting 7e9e708 restore errno in dbg macro 039ba92 more useful tests output b5a7392 add julien to credits fa2ec03 Merge branch 'bplaa-yai-master' 1d91cfe Merge branch 'master' of https://github.com/bplaa-yai/unionfs-fuse into bplaa-yai-master b48fa6a fix travis script 6947e79 more tests 341dfc8 formatting b2d8426 whitespace formatting c393877 prepare mknod test 99a529c typo fix 5df6aec add test case for mkdir and sync (not working) f15bc13 add tests to makefile 8ef0b14 more tests e0e8233 add coverage files to gitignore and clean it up a bit 0460915 whitespace formatting f0acead whitespace formatting 80be111 make unionfs_oper accessible outside of its compilation unit a016d2d make add_branch and parse_branches accessible outside of their compilation unit 1df24c6 add rules for static and shared libraries, update objects list d4e62eb separate main logic from fuse ops handlers Also remove patch already in version. Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io> Signed-off-by: Khem Raj <raj.khem@gmail.com>

flir-image-sherlock image now adds components: lighttpd (web server) lighttpd modules (additional web support) haproxy (needed packet proxy) php (needed for http resource access) To activate resource access using http://<camip>/prod/res/..., web files needs to be added to /FLIR/usr/www (in a kit installation) To be able to build the needed flir_res.so (php_flir_res repo) for Sherlock, a new SDK must be first be generated from content in this (yocto) commit (php needs to be present in SDK) The (new) SDK to be installed. php_flir_res source needs a to be checked out from a code branch where cmake "php7" package usage is replaced with "php" Target that starts to use an OS from this commit might need a full "factory default" for haproxy+lighttpd to work. /etc/passwd and /etc/group default content is updated with pseudo-users www-data and haproxy. Updated passwd and group files in ext4 are obscured with overlay versions (which will be the case in a target that had a previous life) yocto php package considerations: php default recipe in yocto2.5 is actually a php7. php7 as a specific package copied from flir-yocto:yocto2.0 does not build Parallell installation of php7 and php5 which we use in flir-yocto (Evander and Bellatrix) for SDK is not possible as of now. Also note the php_7.2.7.bbappend Fixes a build error that appears when valgrind is installed on the build computer See for instance openembedded/meta-openembedded#94 A fix (for meta-openembedded later than in yocto2.5) was introduced as: openembedded/meta-openembedded@840850e By the .bbappend we have a flir backport

Release notes for 0.5.2 ======================= - New Features: - Add a "Viewer Mode" toggle (openembedded#50, !72) - Improve `--quit` option: close all windows interactively (!71) - Improve encoding management (openembedded#42, !69) - Display the current encoding in the status bar - Make the default encoding configurable via GSettings - Allow to choose encoding in the "Open" and "Save As" dialogs (openembedded#42) - Add a command line option to choose encoding - Add a "Delete Line" action (openembedded#13, !66) - Make automatic addition of the last EOL character configurable (openembedded#53,!65) - Switch to GFile for I/O operations (openembedded#4, openembedded#27, openembedded#75, !64) - Add file monitoring (openembedded#75) - Add a setting to create a tilde-backup file when saving (openembedded#27) - Make saving atomic (openembedded#4) - Appearance Changes: - Filter files on mime type in the "Open" and "Save As" dialogs (openembedded#2, openembedded#35, !67) - Code Refactoring: - Improve encoding management (openembedded#42, !69) - Make encoding dialog more generic and self-contained - Encodings definition review - Clarify encoding management when opening files - Improve unicode BOM management - Switch to GFile for I/O operations (openembedded#4, openembedded#27, openembedded#75, !64) - Set the save action sensitivity more precisely - Let GFile APIs check for file existence when reading - Let GFile APIs check for external modifications when saving - Basic switch to GFile for I/O operations - Bug Fixes: - Make "replace" and "replace all" behaviors consistent (openembedded#94) - Ensure that the page setup is properly applied when printing (openembedded#90) - Avoid character escape issues in menu item action names (openembedded#91) - Properly initialize document search properties - Avoid illegal memory access when searching with tab changes (!73) - Revert to "Wrap Around" always true for the search bar (openembedded#83) - Prevent too late accesses to the buffer in selection mode - Direct call to keybinding signals for "Delete" and "Select All" (openembedded#83) - Improve editing keybindings consistency (openembedded#83) - Translation Updates Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>

Release notes for 0.5.2 ======================= - New Features: - Add a "Viewer Mode" toggle (openembedded#50, !72) - Improve `--quit` option: close all windows interactively (!71) - Improve encoding management (openembedded#42, !69) - Display the current encoding in the status bar - Make the default encoding configurable via GSettings - Allow to choose encoding in the "Open" and "Save As" dialogs (openembedded#42) - Add a command line option to choose encoding - Add a "Delete Line" action (openembedded#13, !66) - Make automatic addition of the last EOL character configurable (openembedded#53,!65) - Switch to GFile for I/O operations (openembedded#4, openembedded#27, openembedded#75, !64) - Add file monitoring (openembedded#75) - Add a setting to create a tilde-backup file when saving (openembedded#27) - Make saving atomic (openembedded#4) - Appearance Changes: - Filter files on mime type in the "Open" and "Save As" dialogs (openembedded#2, openembedded#35, !67) - Code Refactoring: - Improve encoding management (openembedded#42, !69) - Make encoding dialog more generic and self-contained - Encodings definition review - Clarify encoding management when opening files - Improve unicode BOM management - Switch to GFile for I/O operations (openembedded#4, openembedded#27, openembedded#75, !64) - Set the save action sensitivity more precisely - Let GFile APIs check for file existence when reading - Let GFile APIs check for external modifications when saving - Basic switch to GFile for I/O operations - Bug Fixes: - Make "replace" and "replace all" behaviors consistent (openembedded#94) - Ensure that the page setup is properly applied when printing (openembedded#90) - Avoid character escape issues in menu item action names (openembedded#91) - Properly initialize document search properties - Avoid illegal memory access when searching with tab changes (!73) - Revert to "Wrap Around" always true for the search bar (openembedded#83) - Prevent too late accesses to the buffer in selection mode - Direct call to keybinding signals for "Delete" and "Select All" (openembedded#83) - Improve editing keybindings consistency (openembedded#83) - Translation Updates Signed-off-by: Andreas Müller <schnitzeltony@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Submitted patch was applied 3.24.5 (stable): Gtk: * TreeValueProxy: Mark the copy assignment operator as deleted (Daniel Boles) Issue openembedded#94, merge request !63 Build: * Meson build: Use relative paths to untracked/ (Mingli Yu) Merge request !61 * [gdk|gtk]mmconfig.h.*: Don't dllimport on MinGW (Chun-wei Fan) Issue openembedded#90 (Lukas K.) * Meson build: Make it possible to use gtkmm as a subproject (Kjell Ahlstedt) Merge request !62 (BogDan Vatra) * Meson build: No implicit_include_directories (Kjell Ahlstedt) * MSVC build: Gtk::TreeModelColumnRecord: Export class selectively (Chun-wei Fan) 3.24.4 (stable): The tarball for 3.24.4 has been created with 'meson dist'. If you build with Autotools from the tarball, please read the relevant part of the README file. Build on Windows: * Gtk::TreePath: Export comparison operators (Chun-wei Fan) Issue openembedded#88 (Patrick Storz) (Chun-wei Fan) Merge request !58 Signed-off-by: Andreas Müller <schnitzeltony@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>

kraj closed this as completed Dec 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

php: host config leakage of HAS_VALGRIND #94

php: host config leakage of HAS_VALGRIND #94

abaumfalk commented Sep 19, 2018

fmhess commented Nov 19, 2018

fmhess commented Nov 19, 2018

kraj commented Dec 22, 2018

php: host config leakage of HAS_VALGRIND #94

php: host config leakage of HAS_VALGRIND #94

Comments

abaumfalk commented Sep 19, 2018

fmhess commented Nov 19, 2018

fmhess commented Nov 19, 2018

kraj commented Dec 22, 2018