Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: no internationalization support #93

Closed
rakuco opened this issue Sep 19, 2018 · 4 comments
Closed

nodejs: no internationalization support #93

rakuco opened this issue Sep 19, 2018 · 4 comments

Comments

@rakuco
Copy link

rakuco commented Sep 19, 2018

meta-oe's nodejs recipe currently builds node with --without-intl. That means there's no internationalization support.

One of the consequences is that the inspector module is not built at all. Recent (at least M71 onwards) Chromium releases need the inspector module as part of the build, so I wonder if the recipe can start depending on ICU and pass --with-intl=system-icu to configure.py.

@rakuco
Copy link
Author

rakuco commented Sep 19, 2018

(Using --with-intl=system-icu might require checking if the ICU version provided in a branch matches the one Node expects; in the worst case, I guess --with-intl=small-icu should work)

@graugans
Copy link
Contributor

Hey @rakuco you might take a look at PACKAGECONFIG and create a Pull request which allows one to select weather internationalization is build or not. Which might get tricky when modelling the dependencies DEPENDS = "virtual/libintl" anyway a better place to discuss this is the mailinglist.

@rakuco
Copy link
Author

rakuco commented Sep 19, 2018

I don't see how virtual/libintl is related, but I've sent an email to the list to discuss this.

@kraj
Copy link
Contributor

kraj commented Dec 22, 2018

its fixed in master d7d0cc5

@kraj kraj closed this as completed Dec 22, 2018
texierp added a commit to texierp/meta-openembedded that referenced this issue Apr 13, 2020
This includes the following changes:

8d73296 test message update
31f752f tests reorganization
c9604f7 more updates in credits and news
bbef3ab add brian to credits and update news.
6d9f4c3 whitespace fixes
3a26b75 Merge branch 'master' of https://github.com/rpodgorny/unionfs-fuse
3b46d86 whitespace formatting
9a1765a Merge pull request openembedded#93 from briankendall/mac-fixes
f1bd82a Merge pull request openembedded#94 from lightmare/man-page-typos
34f4840 man page wording
8e145ad man page formatting
2249ae9 fix some man page typos and missing commas
f3fccaf Fix tests in macOS
29d8b6c Fix error code -50 when copying files using Finder in macOS
5f1431a Merge pull request openembedded#90 from h3xx/fix-mandir-path
04ed9a2 Use standard variable for man page install path
2ac5726 updated readme to explain where the cache is
24b46b6 add atha to credits
eaf8397 Fix compilation on macOS
b663b12 annotate ioctl call correctly as DBG()
c8d23a9 whitespace formatting
de61d85 Merge branch 'therealfun-master'
df79b8e minor test improvements
d8d20c2 Implement access() for "cow,relaxed_permissions" use case
b97ff88 typo fix
75a367c formatting
7e9e708 restore errno in dbg macro
039ba92 more useful tests output
b5a7392 add julien to credits
fa2ec03 Merge branch 'bplaa-yai-master'
1d91cfe Merge branch 'master' of https://github.com/bplaa-yai/unionfs-fuse into bplaa-yai-master
b48fa6a fix travis script
6947e79 more tests
341dfc8 formatting
b2d8426 whitespace formatting
c393877 prepare mknod test
99a529c typo fix
5df6aec add test case for mkdir and sync (not working)
f15bc13 add tests to makefile
8ef0b14 more tests
e0e8233 add coverage files to gitignore and clean it up a bit
0460915 whitespace formatting
f0acead whitespace formatting
80be111 make unionfs_oper accessible outside of its compilation unit
a016d2d make add_branch and parse_branches accessible outside of their compilation unit
1df24c6 add rules for static and shared libraries, update objects list
d4e62eb separate main logic from fuse ops handlers

Also remove patch already in version.

Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Apr 13, 2020
This includes the following changes:

8d73296 test message update
31f752f tests reorganization
c9604f7 more updates in credits and news
bbef3ab add brian to credits and update news.
6d9f4c3 whitespace fixes
3a26b75 Merge branch 'master' of https://github.com/rpodgorny/unionfs-fuse
3b46d86 whitespace formatting
9a1765a Merge pull request openembedded#93 from briankendall/mac-fixes
f1bd82a Merge pull request openembedded#94 from lightmare/man-page-typos
34f4840 man page wording
8e145ad man page formatting
2249ae9 fix some man page typos and missing commas
f3fccaf Fix tests in macOS
29d8b6c Fix error code -50 when copying files using Finder in macOS
5f1431a Merge pull request openembedded#90 from h3xx/fix-mandir-path
04ed9a2 Use standard variable for man page install path
2ac5726 updated readme to explain where the cache is
24b46b6 add atha to credits
eaf8397 Fix compilation on macOS
b663b12 annotate ioctl call correctly as DBG()
c8d23a9 whitespace formatting
de61d85 Merge branch 'therealfun-master'
df79b8e minor test improvements
d8d20c2 Implement access() for "cow,relaxed_permissions" use case
b97ff88 typo fix
75a367c formatting
7e9e708 restore errno in dbg macro
039ba92 more useful tests output
b5a7392 add julien to credits
fa2ec03 Merge branch 'bplaa-yai-master'
1d91cfe Merge branch 'master' of https://github.com/bplaa-yai/unionfs-fuse into bplaa-yai-master
b48fa6a fix travis script
6947e79 more tests
341dfc8 formatting
b2d8426 whitespace formatting
c393877 prepare mknod test
99a529c typo fix
5df6aec add test case for mkdir and sync (not working)
f15bc13 add tests to makefile
8ef0b14 more tests
e0e8233 add coverage files to gitignore and clean it up a bit
0460915 whitespace formatting
f0acead whitespace formatting
80be111 make unionfs_oper accessible outside of its compilation unit
a016d2d make add_branch and parse_branches accessible outside of their compilation unit
1df24c6 add rules for static and shared libraries, update objects list
d4e62eb separate main logic from fuse ops handlers

Also remove patch already in version.

Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
iipeace pushed a commit to iipeace/meta-openembedded that referenced this issue Jun 16, 2020
This includes the following changes:

8d73296 test message update
31f752f tests reorganization
c9604f7 more updates in credits and news
bbef3ab add brian to credits and update news.
6d9f4c3 whitespace fixes
3a26b75 Merge branch 'master' of https://github.com/rpodgorny/unionfs-fuse
3b46d86 whitespace formatting
9a1765a Merge pull request openembedded#93 from briankendall/mac-fixes
f1bd82a Merge pull request openembedded#94 from lightmare/man-page-typos
34f4840 man page wording
8e145ad man page formatting
2249ae9 fix some man page typos and missing commas
f3fccaf Fix tests in macOS
29d8b6c Fix error code -50 when copying files using Finder in macOS
5f1431a Merge pull request openembedded#90 from h3xx/fix-mandir-path
04ed9a2 Use standard variable for man page install path
2ac5726 updated readme to explain where the cache is
24b46b6 add atha to credits
eaf8397 Fix compilation on macOS
b663b12 annotate ioctl call correctly as DBG()
c8d23a9 whitespace formatting
de61d85 Merge branch 'therealfun-master'
df79b8e minor test improvements
d8d20c2 Implement access() for "cow,relaxed_permissions" use case
b97ff88 typo fix
75a367c formatting
7e9e708 restore errno in dbg macro
039ba92 more useful tests output
b5a7392 add julien to credits
fa2ec03 Merge branch 'bplaa-yai-master'
1d91cfe Merge branch 'master' of https://github.com/bplaa-yai/unionfs-fuse into bplaa-yai-master
b48fa6a fix travis script
6947e79 more tests
341dfc8 formatting
b2d8426 whitespace formatting
c393877 prepare mknod test
99a529c typo fix
5df6aec add test case for mkdir and sync (not working)
f15bc13 add tests to makefile
8ef0b14 more tests
e0e8233 add coverage files to gitignore and clean it up a bit
0460915 whitespace formatting
f0acead whitespace formatting
80be111 make unionfs_oper accessible outside of its compilation unit
a016d2d make add_branch and parse_branches accessible outside of their compilation unit
1df24c6 add rules for static and shared libraries, update objects list
d4e62eb separate main logic from fuse ops handlers

Also remove patch already in version.

Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Apr 7, 2021
Release notes for 0.5.4
=======================
- New Features:
  - Add --line/-l and --column/-c number (openembedded#107, !83)
  - Port to GtkSourceView 4 (openembedded#55, openembedded#80, !10)

- Bug Fixes:
  - Delay request to scroll to cursor for the correct active view
  - Monitor hardlinks with glib 2.56.2 (openembedded#110, !82)
  - Transfer encoding from remote to primary instance (openembedded#109)
  - Prevent a crash when no language is found
  - Make window require attention when opening new tabs (openembedded#106, openembedded#93, !81)
  - Fix BOM array (!80)
  - Correctly initialize toolbar style combo box (openembedded#103)
  - Allow checking parent sources when looking up schema (openembedded#101)
  - Fix missing parameter to "select-all" signal (!79)

- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead pushed a commit that referenced this issue Apr 8, 2021
Release notes for 0.5.4
=======================
- New Features:
  - Add --line/-l and --column/-c number (#107, !83)
  - Port to GtkSourceView 4 (#55, #80, !10)

- Bug Fixes:
  - Delay request to scroll to cursor for the correct active view
  - Monitor hardlinks with glib 2.56.2 (#110, !82)
  - Transfer encoding from remote to primary instance (#109)
  - Prevent a crash when no language is found
  - Make window require attention when opening new tabs (#106, #93, !81)
  - Fix BOM array (!80)
  - Correctly initialize toolbar style combo box (#103)
  - Allow checking parent sources when looking up schema (#101)
  - Fix missing parameter to "select-all" signal (!79)

- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead pushed a commit that referenced this issue Apr 10, 2021
Release notes for 0.5.4
=======================
- New Features:
  - Add --line/-l and --column/-c number (#107, !83)
  - Port to GtkSourceView 4 (#55, #80, !10)

- Bug Fixes:
  - Delay request to scroll to cursor for the correct active view
  - Monitor hardlinks with glib 2.56.2 (#110, !82)
  - Transfer encoding from remote to primary instance (#109)
  - Prevent a crash when no language is found
  - Make window require attention when opening new tabs (#106, #93, !81)
  - Fix BOM array (!80)
  - Correctly initialize toolbar style combo box (#103)
  - Allow checking parent sources when looking up schema (#101)
  - Fix missing parameter to "select-all" signal (!79)

- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit 60480f8)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants