Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct mismatched bus id #991

Merged
merged 11 commits into from
Nov 15, 2022
Merged

Correct mismatched bus id #991

merged 11 commits into from
Nov 15, 2022

Conversation

nailend
Copy link
Contributor

@nailend nailend commented Oct 19, 2022

Fixes #989 .

The proposed solution in #989 did not work. Therefore we decided for the pragmatic one:
Amenities in cells with different mvgd than the assigned buildings centroid, are dropped.
Synthetic amenities will be created in these.

  • update module docstring

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the
    continuous-integration/run-everything-over-the-weekend-branch.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

@nailend nailend added the 🐛 bug Something isn't working label Oct 19, 2022
@nailend nailend requested a review from nesnoj October 19, 2022 15:17
@nailend nailend self-assigned this Oct 19, 2022
@nailend nailend marked this pull request as draft October 21, 2022 12:44
All amenities with a different bus_id then it's
assigned building centroid, are removed. If there
are no further amenities in the cell. Synthetic
ones will be generated in later steps.
@nailend nailend marked this pull request as ready for review October 24, 2022 14:30
@nesnoj
Copy link
Member

nesnoj commented Oct 27, 2022

You assigned me, but this is still WIP, right? (convert to draft?)
At least the recent changes are not part of the CI. I removed the CI tick above.

@nailend
Copy link
Contributor Author

nailend commented Oct 28, 2022

You assigned me, but this is still WIP, right? (convert to draft?)

At least the recent changes are not part of the CI. I removed the CI tick above.

True, had to refix stuff

@nailend nailend marked this pull request as draft October 28, 2022 20:21
@nailend nailend marked this pull request as ready for review November 13, 2022 15:53
@nailend
Copy link
Contributor Author

nailend commented Nov 15, 2022

You assigned me, but this is still WIP, right? (convert to draft?) At least the recent changes are not part of the CI. I removed the CI tick above.

This should now be through as well @nesnoj

@nailend nailend merged commit 0ff6664 into dev Nov 15, 2022
@nailend nailend deleted the fixes/#989-mismatch-cts-bus-id branch November 15, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch of building bus_ids from cts_heat_demand_building_share and mapping table
2 participants