Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch of building bus_ids from cts_heat_demand_building_share and mapping table #989

Closed
nailend opened this issue Oct 19, 2022 · 0 comments · Fixed by #991
Closed

Mismatch of building bus_ids from cts_heat_demand_building_share and mapping table #989

nailend opened this issue Oct 19, 2022 · 0 comments · Fixed by #991
Assignees

Comments

@nailend
Copy link
Contributor

nailend commented Oct 19, 2022

There is a mismatch of building bus_ids in the result tables demand.egon_cts_heat_demand_building_share and demand.egon_cts_electricity_demand_building_share and the mapping table boundaries.egon_map_zensus_mvgd_buildings.

The mismatch probably results in the process of determining the cts demand share per building. Its is derived from the number of amenities within a census cell. If multiple amenities are tagged to a building which exceeds a census cell, there are edge cases in which not all amenities are assigned to the same mvgd.

  • A building covers multiple census cells
  • these census cells contain amenities tagged to the building
  • theses census cells are assigned to multiple mvgd
  • but the building is only assigned to the substation of the census cell containing its centroid
  • the building gets assigned all demand of the cencus cells covered according to the number of amenities within

A building however can not get demand from different mvgd by logic as well as by our methodology.
This is a problem taken care of here.
All amenities tagged to a building need to be of the mvgd, if not the ones lower in number per mvgd are dropped.
These cells are compensated for with synthetic buildings.

Apparently there are edge cases in which the mvgd chosen is not the one containing the centroid of the building. This leads to an duplicated key error during the heat pump desaggregation.

To fix this, I propose to simply update the zensus_population_id in openstreetmap.egon_cts_buildings here

@nailend nailend self-assigned this Oct 19, 2022
nailend added a commit that referenced this issue Oct 19, 2022
@nailend nailend mentioned this issue Oct 19, 2022
7 tasks
nailend added a commit that referenced this issue Oct 19, 2022
…tion/run-everything-over-the-weekend-2022-10-10
nailend added a commit that referenced this issue Oct 24, 2022
nailend added a commit that referenced this issue Oct 24, 2022
…tion/run-everything-over-the-weekend-2022-10-10
nailend added a commit that referenced this issue Nov 1, 2022
nailend added a commit that referenced this issue Nov 15, 2022
nailend added a commit that referenced this issue Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant