Features/#382 sanity check #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…industrial biomass chp, central biomass chp heat
…ral resistive heater, solar thermal collector, geo thermal and residencial rural heat pump
IlkaCu
reviewed
Mar 29, 2022
| Created on Fri Jan 21 10:49:43 2022 | ||
|
|
||
| @author: student | ||
| """ |
There was a problem hiding this comment.
Please replace line 1 - 7 by a short description what the script is doing. See this example: https://github.com/openego/eGon-data/blob/dev/src/egon/data/datasets/vg250/__init__.py#L1-L10
IlkaCu
reviewed
Mar 29, 2022
| print(f"The target values for Sum loads Heat DE differ by {Error_heat} %") | ||
|
|
||
|
|
||
| sum_urban_central_heat_pump_supply = db.select_dataframe( |
There was a problem hiding this comment.
Missing indentation. This code is outside any function and will not be executed in the eGon-data run
IlkaCu
reviewed
Mar 29, 2022
|
|
||
| print(f"The target values for Sum loads AC DE differ by {Error_AC} %") | ||
|
|
||
| demand_peta_heat = sum_loads_DE_demand_peta_heat[ |
There was a problem hiding this comment.
If I remember right, we preferred to have separate functions for electricity and heat.
IlkaCu
approved these changes
Jun 3, 2022
…go/eGon-data into features/#382-sanity-check
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #382 .
Before merging into
dev-branch, please make sure thatCHANGELOG.rstwas updated.blackandisort.Dataset-version is updated when existing datasets are adjusted.continuous-integration/run-everything-over-the-weekend-v2- branch.test mode.Everythingmode.