Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include checks to ensure data validity #382

Closed
IlkaCu opened this issue Aug 12, 2021 · 2 comments · Fixed by #717
Closed

Include checks to ensure data validity #382

IlkaCu opened this issue Aug 12, 2021 · 2 comments · Fixed by #717
Assignees

Comments

@IlkaCu
Copy link
Member

IlkaCu commented Aug 12, 2021

To ensure the validity of our resulting data, some data checks should be integrated in the workflow. Central resulting tables such as eTraGo tables should be part of the checks.
One useful example:

# If the deviation is > 1%, throw an error
assert (
df_check.deviation.abs().max() < 1
), f"""Unexpected deviation between target value and distributed
heat supply: {df_check}
"""
# Add gas boilers as conventional backup capacities
backup = backup_gas_boilers("eGon2035")
backup.to_postgis(
targets["district_heating_supply"]["table"],
schema=targets["district_heating_supply"]["schema"],
con=db.engine(),
if_exists="append",
)

@nesnoj
Copy link
Member

nesnoj commented Apr 26, 2022

Thanks for taking care!
How can we integrate additional checks?

@nailend Could you add some points/scrips/links to other issues here for validating the HH el. demand that have been used during the development?

@nailend
Copy link
Contributor

nailend commented May 2, 2022

These are a few ideas. The test would not be very precise but more like: is the aggregation of the disaggregated data within a tollerance

  • compare aggregated load at nuts3 to demand-regio
  • compare aggregated refined hh distribution to census hh distribution
  • households > buildings
  • check amount of cells with hh data after imputation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants