Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/#148 drop python36 support #152

Merged
merged 5 commits into from
Mar 11, 2021

Conversation

ClaraBuettner
Copy link
Contributor

Closes #148 Closes #104
This branch drops the support for Python3.6 which is already not working with some functions.
It is also removed from tox testing and GitHub actions.
@gplssm I don't know much about tox or GitHub actions. I ran tox and it worked as I expected, but could you check this again?

@ClaraBuettner ClaraBuettner added 🐛 bug Something isn't working 🧪 testing Tests and CI labels Mar 11, 2021
@ClaraBuettner ClaraBuettner self-assigned this Mar 11, 2021
Copy link
Contributor

@gplssm gplssm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Could you please add a note in the CHANGELOG about dropping Python 3.6 support? This would be cool. And then, please merge 🎉

@ClaraBuettner ClaraBuettner merged commit 45f841b into dev Mar 11, 2021
@ClaraBuettner ClaraBuettner deleted the features/#148-drop-python36-support branch March 22, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🧪 testing Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python3.6 egon.data.subprocess fails with Python3.6
2 participants