Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python3.6 #148

Closed
1 of 3 tasks
ClaraBuettner opened this issue Mar 9, 2021 · 2 comments · Fixed by #152
Closed
1 of 3 tasks

Drop support for Python3.6 #148

ClaraBuettner opened this issue Mar 9, 2021 · 2 comments · Fixed by #152
Assignees
Labels
🐛 bug Something isn't working

Comments

@ClaraBuettner
Copy link
Contributor

ClaraBuettner commented Mar 9, 2021

There are functions which fail with python3.6 (see #104) but it is still included in the setup.py and the automatic test. This should be resolved.

  • remove python3.6 from setup.py
  • remove python3.6 from github-actions
  • remove python3.6 from tox testing
@ClaraBuettner ClaraBuettner added the 🐛 bug Something isn't working label Mar 9, 2021
@ClaraBuettner
Copy link
Contributor Author

I think I was also able to remove Python3.6 from tox testing and GitHub actions. The tox testing seem to work, but I don't know how I can test the GitHub actions without creating a PR.

@gplssm
Copy link
Contributor

gplssm commented Mar 11, 2021

I think I was also able to remove Python3.6 from tox testing and GitHub actions. The tox testing seem to work, but I don't know how I can test the GitHub actions without creating a PR.

Thanks for doing all this! 👏
It's totally fine to create a PR in order to test the GitHub actions workflow. If you are in a situation you want to do this but you aren't finished with the feature, simply mark the PR as "draft" and everyone knows it's work in progress. It might be still valuable for others to see the coming changes in a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants