Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: hover for danger button #2844

Conversation

khudym
Copy link
Contributor

@khudym khudym commented Nov 23, 2023

Description

add hover styles for dark button
Issue

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Nov 23, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @khudym!

When this pull request is ready, tag your edX technical lead.

@khudym khudym mentioned this pull request Nov 23, 2023
10 tasks
@khudym
Copy link
Contributor Author

khudym commented Nov 23, 2023

Old PR: #2675

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b081084) 91.90% compared to head (4e94cdc) 93.13%.
Report is 92 commits behind head on release/chip-searchfield-pagination.

Additional details and impacted files
@@                           Coverage Diff                           @@
##           release/chip-searchfield-pagination    #2844      +/-   ##
=======================================================================
+ Coverage                                91.90%   93.13%   +1.22%     
=======================================================================
  Files                                      235      235              
  Lines                                     4310     4586     +276     
  Branches                                  1044     1161     +117     
=======================================================================
+ Hits                                      3961     4271     +310     
+ Misses                                     345      311      -34     
  Partials                                     4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit 962d007 into openedx:release/chip-searchfield-pagination Dec 8, 2023
15 checks passed
viktorrusakov pushed a commit that referenced this pull request Dec 28, 2023
adamstankiewicz pushed a commit that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants