Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchField.SubmitButton with variant="dark" has no hover styles #2650

Closed
adamstankiewicz opened this issue Sep 22, 2023 · 2 comments · Fixed by edx/brand-edx.org#77
Closed

SearchField.SubmitButton with variant="dark" has no hover styles #2650

adamstankiewicz opened this issue Sep 22, 2023 · 2 comments · Fixed by edx/brand-edx.org#77
Assignees
@khudym
Labels
bug Report of or fix for something that isn't working as intended

Comments

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Sep 22, 2023 •
edited
Loading

The SearchField.SubmitButton component, when located externally and with variant="dark", does not have proper styles according to the Button spec on hover. Interestingly, when variant="light", the SearchField.SubmitButton component does have proper hover styles for its color variant.

image

image

Playground Example
@adamstankiewicz adamstankiewicz changed the title <SearchField.SubmitButton submitButtonLocation="external" variant="dark" /> has no hover styles SearchField.SubmitButton with variant="dark" has no hover styles Sep 22, 2023
@adamstankiewicz adamstankiewicz added the bug Report of or fix for something that isn't working as intended label Sep 22, 2023
@adamstankiewicz adamstankiewicz moved this from Backlog to To Do in Paragon Working Group Sep 25, 2023
@khudym khudym mentioned this issue Sep 29, 2023
Closed
10 tasks
@khudym
Copy link
Contributor

khudym commented Sep 29, 2023

PR: #2675

@viktorrusakov viktorrusakov linked a pull request Oct 2, 2023 that will close this issue
[BD-46] fix: hover for danger button #2675
Closed
10 tasks
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from To Do to In progress in Paragon Working Group Oct 5, 2023
@viktorrusakov viktorrusakov mentioned this issue Oct 6, 2023
Merged
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from In progress to In review in Paragon Working Group Oct 6, 2023
@viktorrusakov
Copy link
Contributor

Related PR from the brand repo: edx/brand-edx.org#77

@khudym khudym mentioned this issue Nov 23, 2023
Merged
10 tasks
@github-project-automation github-project-automation bot moved this from In review to Done in Paragon Working Group Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khudym khudym

Labels
bug Report of or fix for something that isn't working as intended
Projects
Paragon Working Group
Status: Done
Milestone
No milestone
3 participants
@adamstankiewicz @khudym @viktorrusakov