Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: do not override SearchField styles #77

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

viktorrusakov
Copy link
Contributor

@viktorrusakov viktorrusakov commented Oct 6, 2023

This PR together with openedx/paragon#2675 fix openedx/paragon#2650 by removing old and unnecessarry overrides of SearchField component. This way SearchField will inherit button styles from Paragon's Button component which will solve design issues with the component.

Note that consuming MFEs will need to upgrade versions of brand-edx.org package and Paragon together in one commit in order for the fix to work.

@openedx-webhooks
Copy link

Thanks for the pull request, @viktorrusakov!

When this pull request is ready, tag your edX technical lead.

Thanks for your pull request, but this repo does not accept outside contributions unless they are under contract. If you think this is an error, please contact @nedbat.

Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MichaelRoytman MichaelRoytman merged commit c051498 into edx:master Jun 4, 2024
1 of 2 checks passed
@edx-semantic-release
Copy link
Collaborator

🎉 This PR is included in version 2.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchField.SubmitButton with variant="dark" has no hover styles
7 participants