feat: adds LEARNING_BASE_URL to config #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaisdar001
force-pushed
the
awaisdar001-patch-1
branch
from
ce211d3 to
c2638ee
Compare
|
Note that you'll want to add this new variable to Also, would you be able to add a PR to update the environment variable documentation here? https://github.com/edx/edx-developer-docs/blob/master/docs/micro_frontends/index.rst I would have mentioned it earlier but forgot! |
|
@davidjoy added the suggested changes, thanks for helping me out here. I really appreciate that. |
davidjoy
reviewed
Nov 2, 2021
src/setupTest.js
Outdated
| process.env.ECOMMERCE_BASE_URL = 'http://localhost:18130'; | ||
| process.env.LANGUAGE_PREFERENCE_COOKIE_NAME = 'openedx-language-preference'; | ||
| process.env.LMS_BASE_URL = 'http://localhost:18000'; | ||
| process.env.LOGIN_URL = 'http://localhost:2000'; |
There was a problem hiding this comment.
Watch out! This says LOGIN_URL still. 😀
davidjoy
suggested changes
Nov 2, 2021
davidjoy
changed the title
This PR adds `config.LEARNING_BASE_UR` for all frontends to use.
awaisdar001
force-pushed
the
awaisdar001-patch-1
branch
from
c7ccd28 to
21b3bf0
Compare
|
Done - I will update the docs after this PR is merged. |
davidjoy
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TNL-8896
TNL-9227
Related PRs:
course authoring mfe: openedx/frontend-app-authoring#210
edge: https://github.com/edx/edge-internal/pull/395/files
edX: https://github.com/edx/edx-internal/pull/5672
Description:
This PR adds
config.LEARNING_BASE_URLfor all frontends to use.Merge checklist:
frontend-platform. This can be done by runningnpm startand opening http://localhost:8080.module.config.jsfile infrontend-build.fix,feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: