fix: the view live button should link to the learning MFE [BD-38] [TNL-8896] [BB-5075] #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @xitij2000! I've created BLENDED-1002 to keep track of it in Jira. More details are on the BD-38 project page. When this pull request is ready, tag your edX technical lead. |
openedx-webhooks
added
blended
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 65.99% 66.53% +0.53%
==========================================
Files 93 94 +1
Lines 1685 1751 +66
Branches 373 392 +19
==========================================
+ Hits 1112 1165 +53
- Misses 548 556 +8
- Partials 25 30 +5
Continue to review full report at Codecov.
|
|
@xitij2000 I am checking with devs internally about the configuration that would be needed for prod. Until we figure that out, this PR would have to wait. |
4 tasks
|
Added settings in the frontend platform. Once the openedx/frontend-platform#243 is merged, we should be ok to proceed and merge this change. 👍 |
awaisdar001
suggested changes
Nov 2, 2021
|
👍 as long as the discussion about the default value for config is resolved.
|
awaisdar001
suggested changes
Nov 9, 2021
|
@awaisdar001 Done |
awaisdar001
approved these changes
Nov 9, 2021
The view live button now links to the learning MFE.
xitij2000
force-pushed
the
kshitij/tnl-8896/view-live
branch
from
ea098df to
cf86f83
Compare
|
@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
cgaber2045
pushed a commit
to cgaber2045/frontend-app-course-authoring
that referenced
this pull request
Jan 14, 2022
The view live button now links to the learning MFE.
KristinAoki
pushed a commit
that referenced
this pull request
Apr 23, 2024
* feat: group configurations - index page * feat: [AXIMST-63] Index group configurations page * fix: resolve discussions * fix: resolve second round discussions * feat: group configurations - content group actions * feat: [AXIMST-75, AXIMST-69, AXIMST-81] Content group actions * fix: resolve conversations * feat: group configurations - sidebar * feat: [AXIMST-87] group-configuration page sidebar * refactor: [AXIMST-87] add changes after review * refactor: [AXIMST-87] add changes after review * refactor: [AXIMST-87] add changes ater review --------- Co-authored-by: Kyrylo Hudym-Levkovych <kyr.hudym@kyrs-MacBook-Pro.local> * fix: group configurations - the page reloads after the user saves changes * feat: group configurations - experiment groups * feat: [AXIMST-93, 99, 105] Group configuration - Experiment Groups * fix: [AXIMST-518, 537] Group configuration - resolve bugs * fix: review discussions * fix: revert classname case * fix: group configurations - resolve discussions fix: [AXIMST-714] icon is aligned with text (#210) * fix: add hook tests * fix: add thunk tests * fix: add slice tests * chore: group configurations - messages * fix: group configurations - remove delete in edit mode --------- Co-authored-by: Kyr <40792129+khudym@users.noreply.github.com> Co-authored-by: Kyrylo Hudym-Levkovych <kyr.hudym@kyrs-MacBook-Pro.local> Co-authored-by: monteri <lansevermore>
bradenmacdonald
pushed a commit
to open-craft/frontend-app-authoring
that referenced
this pull request
Aug 9, 2024
This PR aims to fix the commit mistakes I made when trying to merge with a refactored fork. This will keep the changes I made in the refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The view live button now links to the learning MFE.
Depends On: openedx/frontend-platform#243
Author's Notes:
This will need changes to configuration to pass along the configuration params needed.