Deprecate react-unit-test-utils and cleanup #382
Conversation
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
diana-villalvazo-wgu
added
the
mao-onboarding
diana-villalvazo-wgu
force-pushed
the
307/deprReactUnitTestUtils
branch
from
dc2abe9 to
b23e8a9
Compare
diana-villalvazo-wgu
force-pushed
the
307/deprReactUnitTestUtils
branch
from
b23e8a9 to
661ba4d
Compare
diana-villalvazo-wgu
moved this from Waiting on Author
to Ready for Review
in Contributions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 144 144
Lines 2196 2196
Branches 476 476
=======================================
Hits 1980 1980
Misses 208 208
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
This looks great!
I left one comment with a question, but I don't consider it blocking.
Thank you so much for all of the work you've done to get react-unit-test-utils fully DEPR'd!
| jest.mock('@edx/frontend-platform/i18n', () => ({ | ||
| ...jest.requireActual('@edx/frontend-platform/i18n'), | ||
| useIntl: () => ({ | ||
| formatMessage: (message, values) => { | ||
| if (message.defaultMessage && values) { | ||
| return message.defaultMessage.replace('{earned}', values.earned).replace('{possible}', values.possible); | ||
| } | ||
| return message.defaultMessage; | ||
| }, | ||
| }), | ||
| })); |
There was a problem hiding this comment.
Does using the formatMessage from testUtils.jsx not work here? It seems like the logic should be almost the same (the only thing that stands out as different is this one having the check for message.defaultMessage being falsy)
There was a problem hiding this comment.
it was failing but i think i found the root cause, will change it back to testUtils mock :)
3 participants
Description
As part of the effort for depracate react-unit-test-utils, the following changes were addressed as part of this PR:
renderWithIntlfromtestUtilsto avoid repetitive code on testsreact-unit-test-utilspackageSupport Information
Need to close PR #381 before reviewing/merge this one
Closes #306
Closes #305