fix: first section celebration #1044
Conversation
Fix the first section celebration modal showing logic. On Nutmeg+ it's shown only after the page reload or after going directly to the second section from the course home. Going through the course with the Next/Previous buttons has no effect (which worked on Maple). Notes: - the weekly goal has the same showing logic, but I assume that is correct behavior so no changes are added for it in this commit. - showing a celebration modal for the first section completion when going directly to the first unit of the second section seems to be a bug (reproduces on Maple too)
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
itsjeyd
added
product review
|
@ProductRyan I'll consider this backport approved from the product perspective, but let me know if you have any objections. |
|
@dyudyunov Once #976 gets a green build, could you make sure that this PR is up-to-date with all the latest changes from #976? Then we'll be able to run tests one more time and hand this over to the engineering team for review. |
itsjeyd
added
waiting on author
|
@leangseu-edx could you check this one too? this is a backport from the recently merged PR to master |
itsjeyd
removed
the
waiting on author
|
@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
4 participants
Fix the first section celebration modal showing logic.
On Nutmeg+ it's shown only after the page reloads or after going directly to the second section from the course home. Going through the course with the Next/Previous buttons has no effect (which worked on Maple).
Notes: