fix: first section celebration #976

dyudyunov · 2022-09-14T15:15:20Z

Fix the first section celebration modal showing logic.

On Nutmeg+ it's shown only after the page reload or after going directly
to the second section from the course home. Going through the course
with the Next/Previous buttons has no effect (which worked on Maple).

Notes:

the weekly goal has the same showing logic, but I assume that is
correct behavior so no changes are added for it in this commit.
showing a celebration modal for the first section completion when
going directly to the first unit of the second section seems to be a bug
(reproduces on Maple too)

openedx-webhooks · 2022-09-14T15:15:22Z

Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

natabene · 2022-09-19T15:51:18Z

@dyudyunov Thank you for the contribution, looks like this is ready for our review.

dyudyunov · 2022-09-19T15:52:26Z

@dyudyunov Thank you for the contribution, looks like this is ready for our review.

hi @natabene
yes, it's ready

codecov · 2022-09-19T15:57:59Z

Codecov Report

Base: 86.83% // Head: 86.93% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (517f535) compared to base (894e16d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
+ Coverage   86.83%   86.93%   +0.10%     
==========================================
  Files         252      252              
  Lines        4329     4333       +4     
  Branches     1096     1096              
==========================================
+ Hits         3759     3767       +8     
+ Misses        551      547       -4     
  Partials       19       19

Impacted Files	Coverage Δ
src/courseware/course/Course.jsx	`88.88% <100.00%> (+0.65%)`	⬆️
...courseware/course/celebration/CelebrationModal.jsx	`100.00% <100.00%> (ø)`
src/courseware/course/celebration/utils.jsx	`92.30% <100.00%> (+16.30%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

muselesscreator

Please add tests for the new behaviors

itsjeyd · 2022-12-15T10:21:51Z

Hey @dyudyunov, just a quick update that I'm labeling this as waiting-for-author for now.

Let us know when you're done adding tests and the changes are ready for review again.

dyudyunov · 2022-12-19T12:53:46Z

hi @itsjeyd @muselesscreator

please, run checkers and review

itsjeyd · 2022-12-22T08:18:40Z

Thanks @dyudyunov!

@muselesscreator Looks like we're good to go here, please have another look.

dyudyunov · 2022-12-27T10:17:43Z

rebased on the top of master branch

mphilbrick211 · 2023-01-11T01:35:40Z

@itsjeyd FYI, I removed the "needs test run" label as tCRIL enabled them.

itsjeyd · 2023-01-11T09:24:13Z

Thanks @mphilbrick211.

Moved to Needs Product Review on the board as that seems to be the immediate next step here. CC @jmakowski1123

@dyudyunov Looks like there's a small linting issue. If you want to fix that in the meantime, great :) But no rush.

dyudyunov · 2023-01-11T10:30:46Z

Thanks @mphilbrick211.

Moved to Needs Product Review on the board as that seems to be the immediate next step here. CC @jmakowski1123

@dyudyunov Looks like there's a small linting issue. If you want to fix that in the meantime, great :) But no rush.

pushed the fix for the lint issue, please, restart the checkers

mphilbrick211 · 2023-01-11T21:53:58Z

@itsjeyd - flagging this for tCRIL to enable tests!

ProductRyan · 2023-01-12T14:21:31Z

@dyudyunov - can you describe what your fix is? where does your code show the celebration?

dyudyunov · 2023-01-13T08:33:51Z

@dyudyunov - can you describe what your fix is? where does your code show the celebration?

hi @ProductRyan
This fix doesn't change the place where the 1st section celebration is shown but when.
The problem itself:

starting from Nutmeg release the 1st section celebration (after the actual completion of the first section) is shown after
- the page reload
- or going directly from the course home to the second section

Expected result (as it was on the Maple release):

user can see the 1st section celebration popup after clicking the "Next" button

dyudyunov · 2023-01-13T12:36:24Z

created a backport to olive: #1044

itsjeyd · 2023-01-17T10:46:19Z

@ProductRyan Thanks for getting product review started here!

For reference, here is a list of related PRs:

fix: first section celebration #977 (Nutmeg backport)
fix: first section celebration #1044 (Olive backport)

I've put these in Needs Product Review on the contributions board for now; happy to update to In Product Review if you think that's more appropriate.

CC @jmakowski1123

jmakowski1123 · 2023-01-31T16:37:52Z

Going forward, this is the master ticket under product review.
Related PRs are:

Removing Product Review label from 977 and 1044.

ProductRyan · 2023-02-02T19:21:56Z

This makes sense - approved. @itsjeyd can you move it, and it's related back ports along?

itsjeyd · 2023-02-03T09:39:25Z

@ProductRyan Sure, done! Thanks for the ping.

@muselesscreator A heads-up that this PR, as well as Nutmeg (#977) and Olive (#1044) backports, should be ready for a final round of engineering review shortly.

@dyudyunov Please resolve merge conflicts. We'll enable tests again once that's done (CC @e0d).

Fix the first section celebration modal showing logic. On Nutmeg+ it's shown only after the page reload or after going directly to the second section from the course home. Going through the course with the Next/Previous buttons has no effect (which worked on Maple). Notes: - the weekly goal has the same showing logic, but I assume that is correct behavior so no changes are added for it in this commit. - showing a celebration modal for the first section completion when going directly to the first unit of the second section seems to be a bug (reproduces on Maple too)

dyudyunov · 2023-02-06T10:25:44Z

@itsjeyd

@dyudyunov Please resolve merge conflicts. We'll enable tests again once that's done (CC @e0d).

done

itsjeyd · 2023-02-08T09:50:59Z

Thanks @dyudyunov!

@e0d This is ready for another round of test runs.

e0d · 2023-02-14T19:46:41Z

@itsjeyd tests running.

leangseu-edx

LGTM 👍

openedx-webhooks · 2023-02-14T21:54:45Z

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 14, 2022

dyudyunov mentioned this pull request Sep 14, 2022

fix: first section celebration #977

Merged

ghassanmas mentioned this pull request Nov 3, 2022

PR(s) Needs to be backported or created to Olive openedx/wg-build-test-release#205

Closed

muselesscreator reviewed Dec 5, 2022

View reviewed changes

itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 15, 2022

dyudyunov force-pushed the fix-first-section-celebration branch from 653c8e7 to 99a30f5 Compare December 19, 2022 12:52

openedx-webhooks removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 19, 2022

dyudyunov requested a review from muselesscreator December 19, 2022 12:54

itsjeyd added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Dec 21, 2022

dyudyunov force-pushed the fix-first-section-celebration branch from 99a30f5 to bc8713a Compare December 27, 2022 09:43

itsjeyd added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 6, 2023

jmakowski1123 added the product review PR requires product review before merging label Jan 10, 2023

mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 11, 2023

dyudyunov force-pushed the fix-first-section-celebration branch from bc8713a to 51c8f0c Compare January 11, 2023 10:29

mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 11, 2023

ProductRyan self-assigned this Jan 12, 2023

dyudyunov mentioned this pull request Jan 13, 2023

fix: first section celebration #1044

Merged

itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Feb 3, 2023

dyudyunov force-pushed the fix-first-section-celebration branch from 51c8f0c to 517f535 Compare February 6, 2023 10:24

itsjeyd added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Feb 8, 2023

leangseu-edx approved these changes Feb 14, 2023

View reviewed changes

leangseu-edx merged commit cd430eb into openedx:master Feb 14, 2023

dyudyunov deleted the fix-first-section-celebration branch February 15, 2023 08:30

e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 27, 2023

fix: first section celebration #976

fix: first section celebration #976

Uh oh!

Conversation

dyudyunov commented Sep 14, 2022

Uh oh!

openedx-webhooks commented Sep 14, 2022

Uh oh!

natabene commented Sep 19, 2022

Uh oh!

dyudyunov commented Sep 19, 2022

Uh oh!

codecov bot commented Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

muselesscreator left a comment

Choose a reason for hiding this comment

Uh oh!

itsjeyd commented Dec 15, 2022

Uh oh!

dyudyunov commented Dec 19, 2022

Uh oh!

itsjeyd commented Dec 22, 2022

Uh oh!

dyudyunov commented Dec 27, 2022

Uh oh!

mphilbrick211 commented Jan 11, 2023

Uh oh!

itsjeyd commented Jan 11, 2023

Uh oh!

dyudyunov commented Jan 11, 2023

Uh oh!

mphilbrick211 commented Jan 11, 2023

Uh oh!

ProductRyan commented Jan 12, 2023

Uh oh!

dyudyunov commented Jan 13, 2023

Uh oh!

dyudyunov commented Jan 13, 2023

Uh oh!

itsjeyd commented Jan 17, 2023

Uh oh!

jmakowski1123 commented Jan 31, 2023

Uh oh!

ProductRyan commented Feb 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsjeyd commented Feb 3, 2023

Uh oh!

dyudyunov commented Feb 6, 2023

Uh oh!

itsjeyd commented Feb 8, 2023

Uh oh!

e0d commented Feb 14, 2023

Uh oh!

leangseu-edx left a comment

Choose a reason for hiding this comment

Uh oh!

openedx-webhooks commented Feb 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

codecov bot commented Sep 19, 2022 •

edited

Loading

ProductRyan commented Feb 2, 2023 •

edited

Loading