Skip to content

Conversation

@xitij2000
Copy link
Contributor

Fix styling of delete message to reduce gaps between paras
Fix bold font on collapsed title of group
Add no groups found error message when trying to enable teams without groups defined

@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program needs triage labels Oct 25, 2021
@openedx-webhooks
Copy link

Thanks for the pull request, @xitij2000! I've created BLENDED-993 to keep track of it in Jira. More details are on the BD-38 project page.

When this pull request is ready, tag your edX technical lead.

@xitij2000 xitij2000 changed the title fix: UX feedback suggestions for teams settings page [BD-38] fix: UX feedback suggestions for teams settings page [BD-38] [TNL-8730] Oct 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #205 (5987135) into master (9fd6cbf) will decrease coverage by 0.55%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   66.54%   65.99%   -0.56%     
==========================================
  Files          93       93              
  Lines        1647     1785     +138     
  Branches      355      401      +46     
==========================================
+ Hits         1096     1178      +82     
- Misses        532      570      +38     
- Partials       19       37      +18     
Impacted Files Coverage Δ
...-resources/app-settings-modal/AppSettingsModal.jsx 0.00% <0.00%> (ø)
src/pages-and-resources/teams/GroupEditor.jsx 0.00% <0.00%> (ø)
src/pages-and-resources/teams/Settings.jsx 0.00% <0.00%> (ø)
src/pages-and-resources/teams/messages.js 0.00% <ø> (ø)
...s/app-config-form/apps/legacy/LegacyConfigForm.jsx 71.42% <0.00%> (-4.77%) ⬇️
src/utils.js 35.48% <0.00%> (-2.82%) ⬇️
src/pages-and-resources/discussions/data/api.js 92.68% <0.00%> (+3.20%) ⬆️
...and-resources/discussions/app-config-form/utils.js 34.78% <0.00%> (+6.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd6cbf...5987135. Read the comment docs.

@xitij2000 xitij2000 force-pushed the kshitij/tnl-8730/take-3 branch from 4150bf5 to 36b0c31 Compare October 25, 2021 13:24
@Cup0fCoffee
Copy link
Contributor

👍

  • I tested this
  • I read through the code
  • n/a I checked for accessibility issues
  • n/a Includes documentation
  • n/a I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

Fix styling of delete message to reduce gaps between paras
Fix bold font on collapsed title of group
Add no groups found error message when trying to enable teams without groups defined
@xitij2000 xitij2000 force-pushed the kshitij/tnl-8730/take-3 branch from 5987135 to 2e8591f Compare October 26, 2021 12:44
@xitij2000 xitij2000 merged commit 6c1b8b6 into master Oct 26, 2021
@xitij2000 xitij2000 deleted the kshitij/tnl-8730/take-3 branch October 26, 2021 18:03
@openedx-webhooks
Copy link

@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

cgaber2045 pushed a commit to cgaber2045/frontend-app-course-authoring that referenced this pull request Jan 14, 2022
Fix styling of delete message to reduce gaps between paras
Fix bold font on collapsed title of group
Add no groups found error message when trying to enable teams without groups defined
bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants