Skip to content

Commit 5987135

Browse files
Apply suggestions from code review
Co-authored-by: Maxim Beder <30300520+Cup0fCoffee@users.noreply.github.com>
1 parent 36b0c31 commit 5987135

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/pages-and-resources/teams/Settings.jsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,11 @@ function TeamSettings({
3939
description: group.description,
4040
max_team_size: group.maxTeamSize,
4141
}));
42-
return saveSettings({ team_sets: groups, max_team_size: values.maxTeamSize, enabled: values.enabled });
42+
return saveSettings({
43+
team_sets: groups,
44+
max_team_size: values.maxTeamSize,
45+
enabled: values.enabled,
46+
});
4347
};
4448
const enableAppError = {
4549
title: intl.formatMessage(messages.noGroupsErrorTitle),
@@ -66,7 +70,7 @@ function TeamSettings({
6670
.test(
6771
'has-groups',
6872
enableAppError,
69-
(value, context) => (value === false || (value === true && context.parent.groups.length > 0)),
73+
(value, context) => (!value || context.parent.groups.length > 0),
7074
),
7175
maxTeamSize: Yup.number()
7276
.required(intl.formatMessage(messages.maxTeamSizeEmpty))

0 commit comments

Comments
 (0)