-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropping Sass support from builtin annotatable block #35716
Conversation
…g with vanilla CSS
d6d57ff
to
b3f2f93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Dropping Sass support from builtin annotatable block
Tickets: #35570
Tasks:
Convert Sass variable into css variables
Compile the css file of the block following given steps.
xmodule/static/css-builtin-blocks
.Replace add_sass_to_fragment to add_css_to_fragment in blocks
.py
fileRemove all .scss files linked to the block under xmodule/assets.
Testing Notes:
npm run build
to run webpack and compile sass files../manage.py lms collectstatic
in lms shell to re-collect static files../manage.py cms collectstatic
in cms shell to re-collect static files.Reference PR:
Here is initial reference PR [Some the changes are only 1 time changes so don't need them in next block PR's.]