feat! Dropping Sass support from builtin video block #35506

farhan · 2024-09-19T13:07:40Z

Dropping Sass support from builtin video block

Tickets: #35570

Tasks:

Convert Sass variable into css variables
Compile the css files of the block following below steps.
- Change this line to the following to avoid adding comments in the compiled css files. This change is only for compilation, revert it when done with compilation.
```
     source_comments: int = SASS_COMMENTS_NONE
```
- Compile the sass to uncompressed CSS using following command
```
      npm run compile-sass-dev
```
- Copy the compiled XBlock linked CSS (lms/static/css/*Display.css and lms/static/css/*Editor.css) into xmodule/static/css-builtin-blocks.
- Format the CSS files using the editor.
- Add those CSS files to version control.
Replace add_sass_to_fragment to add_css_to_fragment in blocksin .py file
Remove all .scss files linked to the block under xmodule/assets.
- Make sure to remove the .scss file in a separate alone commit so reviewer could review scss changes and they stay in history.
- Don't remove the scss file if its linked to some other block.

Testing:

Run npm run build to run webpack and compile sass files.
Run ./manage.py lms collectstatic in lms shell to re-collect static files.
Run ./manage.py cms collectstatic in cms shell to re-collect static files.
Verify the block's compiled css and the css global variables in the LMS
Verify the block's compiled css and the css global variables in the Studio
Test the XBlock rendering and User Experience in LMS
Test the XBlock rendering and User Experience in Studio

Screenshots

xmodule/util/builtin_assets.py

open-craft-grove · 2024-10-11T18:19:29Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-10-14T09:26:49Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-10-14T13:50:37Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-10-16T11:03:06Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

fayyazahmed66 · 2024-10-21T08:18:51Z

I am going to test this as its critical.
CC: @farhan

fayyazahmed66 · 2024-10-23T06:20:58Z

I have tested Video Xblock, Things are working fine.
Here is the report.

farhan · 2024-10-23T06:40:27Z

@fayyazahmed66 Thanks for your valuable testing contribution, appreciated 🌟

ttqureshi · 2024-10-23T06:44:56Z

I am going to review this PR.
CC: @farhan

ttqureshi

I have reviewd the PR. It's good to go 🚀

salman2013

LGTM

open-craft-grove · 2024-10-23T12:04:49Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

kdmccormick

Just some comment corrections.

If I'm merging this PR later in the day anyway, I can apply these before merging.

xmodule/util/builtin_assets.py

… vanilla CSS

open-craft-grove · 2024-10-23T14:22:43Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-10-23T14:54:40Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

kdmccormick

Great work! 🚀

edx-pipeline-bot · 2024-10-24T09:09:37Z

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot · 2024-10-24T09:29:14Z

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot · 2024-10-24T09:29:14Z

2U Release Notice: This PR has been deployed to the edX production environment.

farhan force-pushed the farhan/sass-to-css-video-block branch 3 times, most recently from bd41dcd to a509763 Compare September 21, 2024 12:16

farhan mentioned this pull request Sep 23, 2024

Replace builtin block Sass with vanilla CSS #35300

Open

farhan changed the title ~~Dropping Sass support from builtin video block~~ feat! Dropping Sass support from builtin video block Sep 23, 2024

farhan self-assigned this Sep 23, 2024

farhan marked this pull request as ready for review September 23, 2024 09:13

farhan requested review from kdmccormick, salman2013 and irtazaakram September 23, 2024 09:15

farhan commented Sep 23, 2024

View reviewed changes

xmodule/util/builtin_assets.py Outdated Show resolved Hide resolved

farhan force-pushed the farhan/sass-to-css-video-block branch 4 times, most recently from e4e5992 to a5919c0 Compare October 1, 2024 12:05

farhan mentioned this pull request Oct 1, 2024

Replace builtin blocks Sass with vanilla CSS #35570

Open

16 tasks

farhan requested a review from nsprenkle October 1, 2024 15:48

farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Oct 3, 2024

farhan requested a review from feanil October 11, 2024 12:02

farhan force-pushed the farhan/sass-to-css-video-block branch from 84e9274 to 19a8c75 Compare October 11, 2024 17:39

farhan added the hacktoberfest-accepted Issue accepted for hacktoberfest participants label Oct 11, 2024

farhan force-pushed the farhan/sass-to-css-video-block branch from 19a8c75 to 7dc8eae Compare October 14, 2024 08:58

farhan closed this Oct 14, 2024

farhan reopened this Oct 14, 2024

openedx deleted a comment from open-craft-grove Oct 14, 2024

farhan added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Oct 14, 2024

farhan force-pushed the farhan/sass-to-css-video-block branch from 7dc8eae to d280339 Compare October 14, 2024 13:17

farhan added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Oct 16, 2024

farhan force-pushed the farhan/sass-to-css-video-block branch from d280339 to 7558ad4 Compare October 16, 2024 10:24

ttqureshi approved these changes Oct 23, 2024

View reviewed changes

salman2013 approved these changes Oct 23, 2024

View reviewed changes

farhan force-pushed the farhan/sass-to-css-video-block branch from 7558ad4 to a344a27 Compare October 23, 2024 11:13

kdmccormick reviewed Oct 23, 2024

View reviewed changes

xmodule/util/builtin_assets.py Outdated Show resolved Hide resolved

xmodule/util/builtin_assets.py Outdated Show resolved Hide resolved

xmodule/util/builtin_assets.py Outdated Show resolved Hide resolved

farhan added 2 commits October 23, 2024 18:40

feat!: Dropping Sass support from builtin video block, replacing with…

8fb5b77

… vanilla CSS

chore: remove video block scss files

7764e47

farhan force-pushed the farhan/sass-to-css-video-block branch from 8f58637 to 7764e47 Compare October 23, 2024 13:40

farhan requested a review from kdmccormick October 23, 2024 13:42

Merge branch 'master' into farhan/sass-to-css-video-block

6259520

kdmccormick approved these changes Oct 24, 2024

View reviewed changes

farhan merged commit 0c91b62 into master Oct 24, 2024
49 checks passed

farhan deleted the farhan/sass-to-css-video-block branch October 24, 2024 07:50

farhan mentioned this pull request Oct 24, 2024

Dropping Sass support from builtin annotatable block #35716

Merged

16 tasks

farhan mentioned this pull request Nov 2, 2024

feat!: Replace sass with vanilla css in custom tag block #35759

Draft

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat! Dropping Sass support from builtin video block #35506

feat! Dropping Sass support from builtin video block #35506

farhan commented Sep 19, 2024 •

edited

Loading

open-craft-grove commented Oct 11, 2024

open-craft-grove commented Oct 14, 2024

open-craft-grove commented Oct 14, 2024

open-craft-grove commented Oct 16, 2024

fayyazahmed66 commented Oct 21, 2024

fayyazahmed66 commented Oct 23, 2024

farhan commented Oct 23, 2024

ttqureshi commented Oct 23, 2024

ttqureshi left a comment

salman2013 left a comment

open-craft-grove commented Oct 23, 2024

kdmccormick left a comment

open-craft-grove commented Oct 23, 2024

open-craft-grove commented Oct 23, 2024

kdmccormick left a comment

edx-pipeline-bot commented Oct 24, 2024

edx-pipeline-bot commented Oct 24, 2024

edx-pipeline-bot commented Oct 24, 2024

feat! Dropping Sass support from builtin video block #35506

feat! Dropping Sass support from builtin video block #35506

Conversation

farhan commented Sep 19, 2024 • edited Loading

Tasks:

Testing:

open-craft-grove commented Oct 11, 2024

open-craft-grove commented Oct 14, 2024

open-craft-grove commented Oct 14, 2024

open-craft-grove commented Oct 16, 2024

fayyazahmed66 commented Oct 21, 2024

fayyazahmed66 commented Oct 23, 2024

farhan commented Oct 23, 2024

ttqureshi commented Oct 23, 2024

ttqureshi left a comment

Choose a reason for hiding this comment

salman2013 left a comment

Choose a reason for hiding this comment

open-craft-grove commented Oct 23, 2024

kdmccormick left a comment

Choose a reason for hiding this comment

open-craft-grove commented Oct 23, 2024

open-craft-grove commented Oct 23, 2024

kdmccormick left a comment

Choose a reason for hiding this comment

edx-pipeline-bot commented Oct 24, 2024

edx-pipeline-bot commented Oct 24, 2024

edx-pipeline-bot commented Oct 24, 2024

farhan commented Sep 19, 2024 •

edited

Loading