Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: call python methods from forum v2 #35490

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Commits on Sep 16, 2024

  1. feat: call python methods from forum v2

    - directly call python native APIs from forum v2 for pin, unpin thread,
    commentables count_stats and get user's data by user_id
    - add forum to the edx-platform requirements
    Muhammad Faraz Maqsood authored and Muhammad Faraz Maqsood committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9126017 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. feat: migrate some APIs to native python

    - directly call python native APIs from forum v2 for get parent comment,
    create parent comment and create child comment.
    - rename retrieve_commentables_stats method to get_commentables_stats and
    retrieve_user to get_user.
    Muhammad Faraz Maqsood authored and Muhammad Faraz Maqsood committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5ff3c66 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. feat: pass params to python native APIs

    - refactored code and now pass proper parameters to python native APIs
    instead of a single dict
    Muhammad Faraz Maqsood authored and Muhammad Faraz Maqsood committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    896f9a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. feat: code refactor and migrate delete comment API

    Muhammad Faraz Maqsood authored and Muhammad Faraz Maqsood committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3a7b24b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. fix: user tests

    Ali-Salman29 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bf87423 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. feat: fix tests for get_user API

    - get_user API tests are now passing in test_views.py and test_serializers.py
    - add get_user api patch in all tests
    - fix httppretty request count in some tests
    - fix test_patch_read_non_owner_user test
    Muhammad Faraz Maqsood committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b382053 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. feat: use new coursewaffle flag to run old code

    - add `ENABLE_FORUM_V2` course waffle flag to switch between old code i.e.
    cs_comment_service and new code i.e. forum v2.
    - mock course waffle flag is_enabled method i.e. ENABLE_FORUM_V2.is_enabled(),
    so that old unit tests can be run and passed.
    - refactor code(that parts of code whose native APIs are implemented till now)
    where we call the native APIs
    Muhammad Faraz Maqsood committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    284e7da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cb58346 View commit details
    Browse the repository at this point in the history
  3. fix: resolve inconsistant python dependencies

    - run `make compile-requirements forum`. Error: It appears that the
    Python dependencies in this PR are inconsistent: A re-run of
    `make compile-requirements` produced changes.
    - fix quality checks
    Muhammad Faraz Maqsood committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    740b127 View commit details
    Browse the repository at this point in the history
  4. fix: fix new failing tests

    - fix new tests related to discussion that failed after fixing previous tests
    these are failing due to no.of argument difference
    https://github.com/openedx/edx-platform/actions/runs/11069160532/job/30756121710?pr=35490
    Muhammad Faraz Maqsood committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8cdc9fc View commit details
    Browse the repository at this point in the history