[WIP] feat: call python methods from forum v2 #35490
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- directly call python native APIs from forum v2 for pin, unpin thread, commentables count_stats and get user's data by user_id - add forum to the edx-platform requirements
Faraz32123
force-pushed
the
feat/migrate_APIs_from_http_to_python_call
branch
from
813c770
to
9126017
Compare
This was referenced Sep 16, 2024
regisb
reviewed
Sep 17, 2024
openedx/core/djangoapps/django_comment_common/comment_client/course.py
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/django_comment_common/comment_client/thread.py
Outdated
Show resolved
Hide resolved
- directly call python native APIs from forum v2 for get parent comment, create parent comment and create child comment. - rename retrieve_commentables_stats method to get_commentables_stats and retrieve_user to get_user.
Faraz32123
changed the title
- refactored code and now pass proper parameters to python native APIs instead of a single dict
|
As you folks are building this out, please use a
We can turn this flag on by default for Sumac. |
- get_user API tests are now passing in test_views.py and test_serializers.py - add get_user api patch in all tests - fix httppretty request count in some tests - fix test_patch_read_non_owner_user test
- add `ENABLE_FORUM_V2` course waffle flag to switch between old code i.e. cs_comment_service and new code i.e. forum v2. - mock course waffle flag is_enabled method i.e. ENABLE_FORUM_V2.is_enabled(), so that old unit tests can be run and passed. - refactor code(that parts of code whose native APIs are implemented till now) where we call the native APIs
Faraz32123
force-pushed
the
feat/migrate_APIs_from_http_to_python_call
branch
from
eb04713
to
60703b4
Compare
- run `make compile-requirements forum`. Error: It appears that the Python dependencies in this PR are inconsistent: A re-run of `make compile-requirements` produced changes. - fix quality checks
Faraz32123
force-pushed
the
feat/migrate_APIs_from_http_to_python_call
branch
from
60703b4
to
740b127
Compare
- fix new tests related to discussion that failed after fixing previous tests these are failing due to no.of argument difference https://github.com/openedx/edx-platform/actions/runs/11069160532/job/30756121710?pr=35490
Faraz32123
force-pushed
the
feat/migrate_APIs_from_http_to_python_call
branch
from
3dd43f1
to
8cdc9fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still a work in progress and not yet ready for final review.