-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove the registration.enable_failure_logging temporary Waffle… #32977
Conversation
Thanks for the pull request, @Yagnesh1998! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@dianakhuang all tests have been passed when ever u have time please review them and let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand from the conversation topics above, we would like to remove the logging code entirely along with the toggle itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, this looks good. I'll merge once tests pass.
@Yagnesh1998 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
openedx#32977) * feat: remove the registration.enable_failure_logging temporary WaffleFlag depr84
Description:
It's a temporary toggle that needs to be removed from the platform. It enables the logging of validation errors in the registration process.
Discussion thread: https://discuss.openedx.org/t/deprecation-removal-registration-enable-failure-logging/7463
Supporting information:
We plan to deprecate and remove the registration.enable_failure_logging temporary WaffleFlag.This was a temporary waffle and is no longer needed as per the original issue:openedx/public-engineering#84