Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove the registration.enable_failure_logging temporary Waffle… #32977

Merged
merged 12 commits into from
Aug 22, 2023

Conversation

Yagnesh1998
Copy link
Contributor

Description:
It's a temporary toggle that needs to be removed from the platform. It enables the logging of validation errors in the registration process.

 def _log_validation_errors(self, request, errors, status_code):
        if not REGISTRATION_FAILURE_LOGGING_FLAG.is_enabled():
            return

Discussion thread: https://discuss.openedx.org/t/deprecation-removal-registration-enable-failure-logging/7463
Supporting information:
We plan to deprecate and remove the registration.enable_failure_logging temporary WaffleFlag.This was a temporary waffle and is no longer needed as per the original issue:openedx/public-engineering#84

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 10, 2023

Thanks for the pull request, @Yagnesh1998! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 10, 2023
@Yagnesh1998
Copy link
Contributor Author

@dianakhuang all tests have been passed when ever u have time please review them and let me know.

Copy link
Contributor

@dianakhuang dianakhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand from the conversation topics above, we would like to remove the logging code entirely along with the toggle itself.

Copy link
Contributor

@dianakhuang dianakhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this looks good. I'll merge once tests pass.

@dianakhuang dianakhuang merged commit a5b1fda into openedx:master Aug 22, 2023
83 of 84 checks passed
@openedx-webhooks
Copy link

@Yagnesh1998 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@Yagnesh1998 Yagnesh1998 deleted the edx-depr84 branch August 22, 2023 15:20
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

mehedikhan72 pushed a commit to mehedikhan72/edx-platform that referenced this pull request Aug 24, 2023
openedx#32977)

* feat: remove the registration.enable_failure_logging temporary WaffleFlag depr84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants