Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: registration.enable_failure_logging #84

Closed
Ian2012 opened this issue Jun 10, 2022 · 2 comments
Closed

[DEPR]: registration.enable_failure_logging #84

Ian2012 opened this issue Jun 10, 2022 · 2 comments
Labels
depr Proposal for deprecation & removal per OEP-21 good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community

Comments

@Ian2012
Copy link

Ian2012 commented Jun 10, 2022

Proposal Date

10 June 2022

Ticket Acceptance Date

27 July 2023

Technology Removal Date

27 July 2023

First Open edX Named Release Without This Functionality

Quince

Rationale

It's a temporary toggle that needs to be removed from the platform. It enables the logging of validation errors in the registration process.

 def _log_validation_errors(self, request, errors, status_code):
        if not REGISTRATION_FAILURE_LOGGING_FLAG.is_enabled():
            return
        ...

After removal executed without any validation

Removal

  • The validation here

  • The feature flag definition here

  • This import here and their usages here and here

Replacement

None

Deprecation

No response

Migration

No response

Additional Info

Discussion thread: https://discuss.openedx.org/t/deprecation-removal-registration-enable-failure-logging/7463

@Ian2012 Ian2012 added the depr Proposal for deprecation & removal per OEP-21 label Jun 10, 2022
@dianakhuang dianakhuang moved this from Proposed to Accepted in DEPR: Deprecation & Removal Jul 27, 2023
@dianakhuang dianakhuang added good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community labels Jul 27, 2023
@dianakhuang
Copy link

Whoever picks up this ticket should also be clear about what will be the behavior after the toggle is removed (picking whether it keeps all the log messages or not).

@robrap
Copy link

robrap commented Jul 27, 2023

[inform] I confirmed that edx.org has this disabled, so I am guessing that the disabled behavior is what we want to keep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21 good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community
Projects
Archived in project
Development

No branches or pull requests

3 participants