Fix CI workflow to run tests #250
Conversation
aht007
force-pushed
the
aht/BOM-1139-FIX-CI-WORKFLOW
branch
4 times, most recently
from
7166338
to
1266b7a
Compare
| @@ -45,7 +47,7 @@ test-js: ## run tests using npm | |||
| -./node_modules/gulp/bin/gulp.js test | |||
|
|
|||
| test-python: clean ## run tests using pytest and generate coverage report | |||
| $(TOX)pytest | |||
| $(TOX)pytest --ignore=testserver/test/acceptance | |||
There was a problem hiding this comment.
Ignoring acceptance tests here because they will be run separately with bokchoy
.github/workflows/js-tests.yml
Outdated
| branches: | ||
| - master | ||
| pull_request: | ||
| branches: |
There was a problem hiding this comment.
we can just remove the branches option
There was a problem hiding this comment.
Doing this causes duplicate checks on PRs
| @@ -85,7 +85,7 @@ | |||
| 'rest_framework.throttling.UserRateThrottle', | |||
| ), | |||
| 'DEFAULT_THROTTLE_RATES': { | |||
| 'user': '10/sec', | |||
| 'user': '100/sec', | |||
There was a problem hiding this comment.
Some tests were failing with pytest and @awais786 bhai suggested that we should increase the throttle rate... Those tests passed after this change
aht007
force-pushed
the
aht/BOM-1139-FIX-CI-WORKFLOW
branch
from
5ba9be4
to
659c786
Compare
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage ? 0
=======================================
Files ? 0
Lines ? 0
Branches ? 0
=======================================
Hits ? 0
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
aht007
force-pushed
the
aht/BOM-1139-FIX-CI-WORKFLOW
branch
from
659c786
to
8398532
Compare
aht007
force-pushed
the
aht/BOM-1139-FIX-CI-WORKFLOW
branch
4 times, most recently
from
915d5c9
to
b65e57c
Compare
JIRA ISSUE: BOM-3119
Description
While shifting CI to GitHub Actions there was a syntax issue in the workflow which caused the tests command to be ignored and hence tests were not running. This PR solves that issue and also splits the workflows according to their use case.