Skip to content

Conversation

@akhilerm
Copy link
Contributor

cherry-pick #663

earlier the blockdevice labels map was initialized in the customtag probe
which causes undeclared map, if the labels are used before using customtag probe.
Now the label initialization happens before the probes are run.

Signed-off-by: Akhil Mohan <akhil.mohan@datacore.com>
Signed-off-by: Akhil Mohan <akhil.mohan@datacore.com>
@akhilerm akhilerm changed the title fix(probe): initialize labels before probe start cherry-pick(probe): initialize labels before probe start Dec 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #664 (5ba7144) into v1.8.x (7c64d44) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1.8.x     #664      +/-   ##
==========================================
+ Coverage   45.10%   45.16%   +0.06%     
==========================================
  Files          79       79              
  Lines        3971     3970       -1     
==========================================
+ Hits         1791     1793       +2     
+ Misses       2009     2007       -2     
+ Partials      171      170       -1     
Impacted Files Coverage Δ
cmd/ndm_daemonset/probe/customtagprobe.go 23.33% <ø> (-4.80%) ⬇️
cmd/ndm_daemonset/controller/probe.go 100.00% <100.00%> (ø)
cmd/ndm_daemonset/probe/addhandler.go 70.91% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c64d44...5ba7144. Read the comment docs.

Copy link

@Ab-hishek Ab-hishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@akhilerm akhilerm merged commit a1e8959 into openebs-archive:v1.8.x Dec 24, 2021
@akhilerm akhilerm deleted the fix-labels-issue branch December 24, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants