fix(probe): initialize labels before probe start #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlier the blockdevice labels map was initialized in the customtag probe which causes undeclared map, if the labels are used before using customtag probe. Now the label initialization happens before the probes are run. Signed-off-by: Akhil Mohan <akhil.mohan@datacore.com>
Signed-off-by: Akhil Mohan <akhil.mohan@datacore.com>
akhilerm
force-pushed
the
fix-labels-issue
branch
from
f7e828a to
5ba7144
Compare
Codecov Report
@@ Coverage Diff @@
## develop #663 +/- ##
===========================================
+ Coverage 45.10% 45.11% +0.01%
===========================================
Files 79 79
Lines 3971 3970 -1
===========================================
Hits 1791 1791
+ Misses 2009 2008 -1
Partials 171 171
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan akhil.mohan@datacore.com
Why is this PR required? What issue does it fix?:
NDM crashes when trying to add zpool labels to the disk from used by probe due to uninitialized map.
What this PR does?:
Earlier the blockdevice labels map was initialized in the customtag probe
which causes undeclared map, if the labels are used before using customtag probe.
Now the label initialization happens before the probes are run.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>