Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EfficientPS ROS node #136

Merged
merged 12 commits into from
Oct 25, 2021
Merged

Add EfficientPS ROS node #136

merged 12 commits into from
Oct 25, 2021

Conversation

vniclas
Copy link
Collaborator

@vniclas vniclas commented Oct 15, 2021 •
edited
Loading

This PR adds a ROS node for inference of the panoptic segmentation method EfficientPS.

efficient_ps_node

@vniclas vniclas added the enhancement New feature or request label Oct 15, 2021
@vniclas vniclas self-assigned this Oct 15, 2021
@vniclas vniclas added test sources Run style checks test tools Test the toolkit methods labels Oct 15, 2021
@vniclas vniclas marked this pull request as ready for review October 21, 2021 06:54
passalis
passalis requested changes Oct 22, 2021
View reviewed changes
Copy link
Collaborator

@passalis passalis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, seems fine to me. I think we also need documentation entries in the following files:

vniclas and others added 4 commits October 22, 2021 10:01
@vniclas
Publish only if any subscribers exist
59d9f78
@vniclas
Add documentation and convert from dos to unix line endings
19b1d03
@vniclas
Squashed commit of the following:
28b82d0 
commit 2c79480
Merge: 369373a 1bf21d8
Author: Jelle <43064291+jelledouwe@users.noreply.github.com>
Date:   Fri Oct 22 09:11:42 2021 +0200

    Merge pull request #108 from tasostefas/object-detection-2d-tud-gem

    Object detection 2D: GemLearner

commit 1bf21d8
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Thu Oct 21 09:55:41 2021 +0200

    Remove unused imports

commit c8eca33
Merge: 6dcb5e7 369373a
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Thu Oct 21 09:47:43 2021 +0200

    Add GEM node documentation

commit 6dcb5e7
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Thu Oct 21 09:39:14 2021 +0200

    Remove commented code

commit 33561be
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Thu Oct 21 09:37:35 2021 +0200

    Update license and modification notes

commit f8adfbd
Merge: ef5ff0c 5d05e53
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Wed Oct 20 17:52:24 2021 +0200

    Remove commented code and fix style errors

commit ef5ff0c
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Wed Oct 20 17:22:51 2021 +0200

    Update utils

commit fe09eb2
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Wed Oct 20 17:21:49 2021 +0200

    Add opendr and date to license statement

commit 36c7e75
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Wed Oct 20 17:21:08 2021 +0200

    Add GEM example

commit 5ab801d
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Wed Oct 20 17:20:32 2021 +0200

    Create and use util function for drawing results

commit b6b277a
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Wed Oct 20 17:18:41 2021 +0200

    Add GEM node in README.md

commit 31918f5
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Wed Oct 20 17:17:38 2021 +0200

    Add GEM module to index

commit 954bc54
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Wed Oct 20 17:17:07 2021 +0200

    Update GEM docs

commit b981de1
Merge: 4a3bc16 9883e4e
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Tue Oct 19 09:08:10 2021 +0200

    Merge master into object-detection-2d-tud-gem

commit 5d05e53
Author: Jelle <43064291+jelledouwe@users.noreply.github.com>
Date:   Mon Oct 18 16:04:09 2021 +0200

    Update docs/reference/gem.md

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 7cfa85c
Merge: 613c2aa fa57b2a
Author: Jelle <43064291+jelledouwe@users.noreply.github.com>
Date:   Mon Oct 18 16:02:38 2021 +0200

    Merge branch 'master' into object-detection-2d-tud-gem

commit 613c2aa
Author: Jelle <43064291+jelledouwe@users.noreply.github.com>
Date:   Mon Oct 18 13:51:59 2021 +0200

    Apply suggestions from code review

    Remove redundant commented code

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit cb14db7
Author: Jelle <43064291+jelledouwe@users.noreply.github.com>
Date:   Mon Oct 18 11:25:28 2021 +0200

    Apply suggestions from code review

    Update documentation on GEM in terms of style and add missing arguments.

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 4a3bc16
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Tue Oct 5 13:15:24 2021 +0200

    Remove commented code

commit c8eb57c
Merge: f0cfb09 433b93f
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Oct 4 10:40:44 2021 +0200

    Merge remote-tracking branch 'origin/master' into object-detection-2d-tud-gem

commit f0cfb09
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Oct 4 10:40:28 2021 +0200

    Add utility for aligning color and infrared images

commit 68d679a
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Oct 4 10:22:22 2021 +0200

    Update test_gem.py

commit 5e1afba
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Oct 4 10:21:15 2021 +0200

    Add mobilenet support and return modality weights in infer method

commit 841916a
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Oct 4 10:20:04 2021 +0200

    Add mobilenet support

commit 9c2f2c0
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Oct 4 10:19:14 2021 +0200

    Add classes argument

commit 3e1dfdf
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Oct 4 10:18:42 2021 +0200

    Make use of both color and rgb image input

commit 33027fd
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Oct 4 10:17:33 2021 +0200

    Update detr.py

commit fe68562
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Oct 4 10:15:11 2021 +0200

    Update gem.md

commit 3fbeb50
Merge: 5fc9973 c94c7a6
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Thu Sep 30 15:43:44 2021 +0200

    Merge remote-tracking branch 'origin/master' into object-detection-2d-tud-gem

commit 5fc9973
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Sep 20 08:46:10 2021 +0200

    Add banner and reduce verbosity

commit 2b1246c
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Sep 20 08:45:17 2021 +0200

    Update dependencies

commit a70d955
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Sep 20 08:44:49 2021 +0200

    Put each sentence on a new line and add self to methods

commit e907f59
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Sep 20 08:43:47 2021 +0200

    Add verbosity control

commit e545179
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Mon Sep 20 08:43:07 2021 +0200

    Add control of verbosity in evaluate method.

commit 8553951
Merge: fa80d18 4d69019
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Fri Sep 17 09:58:41 2021 +0200

    Merge remote-tracking branch 'origin/object-detection-2d-tud-detr' into object-detection-2d-tud-gem

commit fa80d18
Merge: c4d1577 22c7acd
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Wed Jul 21 11:59:24 2021 +0200

    Merge remote-tracking branch 'origin/master' into object-detection-2d-tud-gem

commit c4d1577
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Wed Jul 21 11:53:04 2021 +0200

    Created GEM ROS node

commit 181a4c7
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Thu Jul 15 11:48:21 2021 +0200

    Test with smaller dataset

commit 08e1ff5
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Thu Jul 15 11:47:49 2021 +0200

    Allow custom eval dataset location

commit 9ba1c7e
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Thu Jul 15 11:47:17 2021 +0200

    Update docs

commit 693bc8e
Author: jelledouwe <j.d.luijkx@tudelft.nl>
Date:   Wed Jul 14 14:42:28 2021 +0200

    Add GEM
@vniclas
Merge branch 'master' into panoptic-segmentation-ros
dd5d976
@vniclas
Copy link
Collaborator Author

vniclas commented Oct 22, 2021

@passalis Good catch. While adding the required documentation, I realized that projects/opendr_ws/src/perception/README.md was wrongly formatted using Windows line endings. Thus, the extensive change of the file.

@vniclas vniclas requested a review from passalis October 22, 2021 08:24
ad-daniel
ad-daniel approved these changes Oct 25, 2021
View reviewed changes
Copy link
Collaborator

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

passalis
passalis approved these changes Oct 25, 2021
View reviewed changes
Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vniclas vniclas merged commit d77be3f into master Oct 25, 2021
@vniclas vniclas deleted the panoptic-segmentation-ros branch October 25, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passalis passalis passalis approved these changes

@ad-daniel ad-daniel ad-daniel approved these changes

@omichel omichel Awaiting requested review from omichel omichel is a code owner

Assignees

@vniclas vniclas

Labels
enhancement New feature or request test sources Run style checks test tools Test the toolkit methods
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vniclas @passalis @ad-daniel