Adding default_currency variable in UI #87

Manas23601 · 2025-05-29T19:30:37Z

What does this PR change?

It adds a new text box and a button to apply conversion rate changes. Alternatively, one could call an exchange-rate API to do the conversion and update the allocations.
The rate parameter can accept floating point integers up to the 1/100000th position. No negative numbers are allowed.
DEFAULT_CURRENCY constant that can be set as any currency during deployment.

Code Workflow

The changes are as follows.

New rate parameter to the search query.
A side-effect that reads the value from the route updates an internal variable conversionRate. This variable, when changed calls another side effect, that calls the function applyConversionRate to multiply all the allocation resource values in allocationData with the conversion rate.
Another side effect is invoked when allocationData is changed calling setTotalData to update the TotalCost row.

Does this PR relate to any other PRs?

Fix deprecated and missing props in TablePagination #84, I incorporated the changes from here to fix my local deployment
Impacted by this new multiple aggregate feature
I'm running the app using the demo API and I'm neither sure the aggregation API is rightly invoked nor the response data is valid. Since I need someone else to verify the data, I'm going to ignore it for now.

I got this with the new changes locally

I was expecting as is like the deployed demo

Note: The allocation item names do not match. "folding-at-home" is unfound

How will this PR impact users?

It will allow users to set the DEFAULT_CURRENCY as part of the setup during the build & deployment. Every time, a request is made without a currency parameter, it will use the DEFAULT_CURRENCY. The codebase ships with "USD" as default.

Does this PR address any GitHub or Zendesk issues?

How was this PR tested?

Locally

$ BASE_URL=https://demo.infra.opencost.io/model npx parcel serve src/index.html --no-cache

I set the default currency to "AED" in this deployment

Apply Rate Text Box and Button

Apply Rate in Action

Does this PR require changes to documentation?

Yes, Need to mention where DEFAULT_CURRENCY field can be set, which is in src/constants/defaults.js

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

This is an enhancement. I'm not sure if this was part of the next release cycle.

netlify · 2025-05-29T19:30:44Z

✅ Deploy Preview for opencost-ui ready!

Name	Link
🔨 Latest commit	`157c760`
🔍 Latest deploy log	https://app.netlify.com/projects/opencost-ui/deploys/689cf6bac216b00008419676
😎 Deploy Preview	https://deploy-preview-87--opencost-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Manas23601 · 2025-05-29T20:56:41Z

@ameijer, can you review this?

Manas23601 · 2025-08-13T20:26:47Z

Ready for review

…provided in the API Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Signed-off-by: vishy <maxvishy02@gmail.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

for default currency it would start as 1.0 Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Signed-off-by: Ishaan Mittal <ishaanmittal123@gmail.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Signed-off-by: Ishaan Mittal <ishaanmittal123@gmail.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Signed-off-by: Alex Meijer <alexander.meijer@ibm.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Bumps [tspascoal/get-user-teams-membership](https://github.com/tspascoal/get-user-teams-membership) from 2 to 3. - [Release notes](https://github.com/tspascoal/get-user-teams-membership/releases) - [Commits](tspascoal/get-user-teams-membership@v2...v3) --- updated-dependencies: - dependency-name: tspascoal/get-user-teams-membership dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Bumps [@date-io/core](https://github.com/dmtrKovalenko/date-io) from 1.3.13 to 3.2.0. - [Release notes](https://github.com/dmtrKovalenko/date-io/releases) - [Commits](dmtrKovalenko/date-io@v1.3.13...v3.2.0) --- updated-dependencies: - dependency-name: "@date-io/core" dependency-version: 3.2.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.26.8 to 7.28.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.28.0/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-version: 7.28.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Signed-off-by: Andreas Resch <andreas@resch.io> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Signed-off-by: VANSH SHARMA <vansh1910sharma@gmail.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Signed-off-by: Christian Petersen <Christian.Petersen2@ibm.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

ameijer · 2025-10-02T12:50:59Z

@Manas23601 would you consider doing this calculation on the backend? we merged a bunch of currency conversion stuff in there

Manas23601 · 2025-10-02T13:56:24Z

Sure, I can do it

github-actions bot added the needs-follow-up label May 29, 2025

Manas23601 changed the title ~~Adding default_currency varible to use when no location parameter is …~~ Adding default_currency variable in UI May 29, 2025

Manas23601 force-pushed the default_currency branch from 3cd2afa to ee1f0ef Compare May 29, 2025 20:55

Manas23601 force-pushed the default_currency branch from a60c3d7 to 62abdc8 Compare June 1, 2025 13:14

Manas23601 force-pushed the default_currency branch from 58f41e2 to 441e157 Compare August 13, 2025 20:31

Manas23601 and others added 22 commits August 14, 2025 02:01

Adding default_currency varible to use when no location parameter is …

2d7a030

…provided in the API Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

default is USD

c9eb848

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

feat: Add support for multiple aggregations in cost allocation view

21f812f

Signed-off-by: vishy <maxvishy02@gmail.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

add default conversation rate

e890dc3

for default currency it would start as 1.0 Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

add necessary components to support currency conversion

3db42a1

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

add constants for allocationData(now RawData first) and conversionrate

d4fe46d

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

applying conversion rate function

3162ed6

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

fix import errors due to rebase

d8c4f70

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Fix generateTitle function which was erroring out

19fa131

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

mention DEFAULT_CURRENCY variable whereabouts

82506c0

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

fix rebasing issues

8f334fc

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Use free API to do currency conversion

0e4156b

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

remove commented code

29b7c03

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Fix build and publish script

effc249

Signed-off-by: Ishaan Mittal <ishaanmittal123@gmail.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

fix rebase

64f11fb

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

reference step outputs as env

ebc7c69

Signed-off-by: Ishaan Mittal <ishaanmittal123@gmail.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

fix rebase

8177c7d

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

add automation to promote to demo

3eab98e

Signed-off-by: Alex Meijer <alexander.meijer@ibm.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

debugging builds, refactor

9a2e5d9

Signed-off-by: Alex Meijer <alexander.meijer@ibm.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

bugfix

89da9bd

Signed-off-by: Alex Meijer <alexander.meijer@ibm.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

dependabot bot and others added 6 commits August 14, 2025 02:01

fix images and loading of external costs

661e84f

Signed-off-by: Andreas Resch <andreas@resch.io> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Update README.md

f14bf88

Signed-off-by: VANSH SHARMA <vansh1910sharma@gmail.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Remove working directory from build and publish container step

a4fc663

Signed-off-by: Christian Petersen <Christian.Petersen2@ibm.com> Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Add step to checkout opencost-ui in Build and Publish Release workflow

bad98ee

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Change order of checkout steps

e23b8db

Signed-off-by: Manas Sivakumar <manas23601@gmail.com>

Manas23601 force-pushed the default_currency branch from 441e157 to e23b8db Compare August 13, 2025 20:32

Merge branch 'main' into default_currency

157c760

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding default_currency variable in UI #87

Adding default_currency variable in UI #87

Uh oh!

Manas23601 commented May 29, 2025 •

edited

Loading

Uh oh!

netlify bot commented May 29, 2025 •

edited

Loading

Uh oh!

Manas23601 commented May 29, 2025

Uh oh!

Manas23601 commented Aug 13, 2025

Uh oh!

ameijer commented Oct 2, 2025

Uh oh!

Manas23601 commented Oct 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Adding default_currency variable in UI #87

Are you sure you want to change the base?

Adding default_currency variable in UI #87

Uh oh!

Conversation

Manas23601 commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR change?

Code Workflow

Does this PR relate to any other PRs?

I got this with the new changes locally

I was expecting as is like the deployed demo

How will this PR impact users?

Does this PR address any GitHub or Zendesk issues?

How was this PR tested?

I set the default currency to "AED" in this deployment

Apply Rate Text Box and Button

Apply Rate in Action

Does this PR require changes to documentation?

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

Uh oh!

netlify bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for opencost-ui ready!

Uh oh!

Manas23601 commented May 29, 2025

Uh oh!

Manas23601 commented Aug 13, 2025

Uh oh!

ameijer commented Oct 2, 2025

Uh oh!

Manas23601 commented Oct 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Manas23601 commented May 29, 2025 •

edited

Loading

netlify bot commented May 29, 2025 •

edited

Loading