Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go 1.22 and 1.23, rm old versions, bump CI actions, bump golangci-linter #776

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −10
Open

Add Go 1.22 and 1.23, rm old versions, bump CI actions, bump golangci-linter #776

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffd6c62
cmd/oci-runtime-tool: fix govet warning
kolyshkin Aug 15, 2024
486baf8
ci: bump Go and github actions
kolyshkin Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ci: bump Go and github actions 
Go 1.23 is released, making Go 1.21 (and older version) unsupported.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
  • Loading branch information
@kolyshkin
kolyshkin committed Aug 15, 2024
commit 486baf8ddf4f7ef397ff174ed2b6aa6b469d0475
18 changes: 9 additions & 9 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ on:
jobs:

lint:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- uses: actions/setup-go@v3
- uses: actions/setup-go@v5
with:
go-version: 1.20.x
- uses: actions/checkout@v3
- uses: golangci/golangci-lint-action@v3
go-version: 1.x # latest
- uses: actions/checkout@v4
- uses: golangci/golangci-lint-action@v6
with:
version: v1.51.2
version: v1.60

commit:
runs-on: ubuntu-22.04
Expand All @@ -44,14 +44,14 @@ jobs:
strategy:
fail-fast: false
matrix:
go-version: [1.19.x, 1.20.x]
go-version: [1.22.x, 1.23.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should still include 1.19 here for go.mod, right? Or do something clever with the go-version-file: support in setup-go?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it makes sense to test on older Go releases, unless we explicitly want to maintain compatibility with older Go versions (and for now I don't know a reason to do that).

go version in go.mod will raise naturally once we'll start using newer features.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, we're switching to go 1.21 as a minimum in #777

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be ok to use;

The last 2 being the currently supported versions, and the min version to verify that the minimum version specified in go.mod isn't lying.

race: ["-race", ""]

steps:
- name: checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: install go ${{ matrix.go-version }}
uses: actions/setup-go@v3
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
- name: build
Expand Down
Loading