Add Go 1.22 and 1.23, rm old versions, bump CI actions, bump golangci-linter #776
Conversation
Found by golangci-lint v1.60.1: cmd/oci-runtime-tool/main.go:59:17: printf: non-constant format string in call to github.com/sirupsen/logrus.Fatalf (govet) logrus.Fatalf(err.Error()) ^ Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Go 1.23 is released, making Go 1.21 (and older version) unsupported. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
@opencontainers/runtime-tools-maintainers PTAL |
| @@ -44,14 +44,14 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| go-version: [1.19.x, 1.20.x] | |||
| go-version: [1.22.x, 1.23.x] | |||
There was a problem hiding this comment.
We should still include 1.19 here for go.mod, right? Or do something clever with the go-version-file: support in setup-go?
There was a problem hiding this comment.
I'm not sure it makes sense to test on older Go releases, unless we explicitly want to maintain compatibility with older Go versions (and for now I don't know a reason to do that).
go version in go.mod will raise naturally once we'll start using newer features.
There was a problem hiding this comment.
Besides, we're switching to go 1.21 as a minimum in #777
There was a problem hiding this comment.
Would it be ok to use;
minversion (go1.19 or go1.21 after Switch to github.com/moby/sys/capability #777)latestlatest - 1
The last 2 being the currently supported versions, and the min version to verify that the minimum version specified in go.mod isn't lying.
|
@opencontainers/runtime-tools-maintainers PTAL 🙏🏻 |
Mostly a CI refresh. See commits for details.
Closes: #769