validation: use t.Fail when checking for main test errors #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same content in |
dongsupark
force-pushed
the
dongsu/correct-fail-func
branch
from
236e8d0
to
9cc345f
Compare
|
@q384566678 Done. Updated |
So far `util.Fatal()`, which calls `os.Exit(1)`, has been widely used to exit immediately when a critical error happened. Its downside is though that no further function can be called after that moment, even defer functions cannot be called. That's fine if there's nothing to clean up or the test is simple enough. Though it could be an issue, for example, when a test should print out TAP output by calling `t.AutoPlan()`, or when it should clean up something. So let's try to use `util.Fatal()` only for errors from critical cases like errors from `util.GetDefaultGenerator()` or `util.PrepareBundle()`. In case of main test errors, use instead `t.Fail(err.Error())` to print out errors in TAP outputs. Partly addresses opencontainers#582 /cc @liangchenye Signed-off-by: Dongsu Park <dongsu@kinvolk.io>
dongsupark
force-pushed
the
dongsu/correct-fail-func
branch
from
9cc345f
to
fab1de6
Compare
|
Rebased. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far
util.Fatal(), which callsos.Exit(1), has been widely used to exit immediately when a critical error happened. Its downside is though that no further function can be called after that moment, even defer functions cannot be called. That's fine if there's nothing to clean up or the test is simple enough. Though it could be an issue, for example, when a test should print out TAP output by callingt.AutoPlan(), or when it should clean up something.So let's try to use
util.Fatal()only for errors from critical cases like errors fromutil.GetDefaultGenerator()orutil.PrepareBundle(). In case of main test errors, use insteadt.Fail(err.Error())to print out errors in TAP outputs.Partly addresses #582
/cc @liangchenye
Signed-off-by: Dongsu Park dongsu@kinvolk.io