using util.Fatal in a right way #582
Comments
Merged
|
Another issue I found in reviewing #640. |
|
I've just happened to see this issue, and it's true that a |
dongsupark
pushed a commit
to kinvolk-archives/runtime-tools
that referenced
this issue
Jun 1, 2018
So far `util.Fatal()`, which calls `os.Exit(1)`, has been widely used to exit immediately when a critical error happened. Its downside is though that no further function can called after that moment, even defer functions cannot be called. That's fine if there's nothing to clean up or the test is simple enough. Though it could be an issue, for example, when a test should print out TAP output by calling `t.AutoPlan()`, or when it should clean up something. So let's try to use `util.Fatal()` only for errors from critical cases like errors from `util.GetDefaultGenerator()` or `util.PrepareBundle()`. In case of main test errors, use instead `t.Fail(err.Error())` to print out errors in TAP outputs. Partly addresses opencontainers#582 /cc @liangchenye Signed-off-by: Dongsu Park <dongsu@kinvolk.io>
dongsupark
pushed a commit
to kinvolk-archives/runtime-tools
that referenced
this issue
Jun 8, 2018
So far `util.Fatal()`, which calls `os.Exit(1)`, has been widely used to exit immediately when a critical error happened. Its downside is though that no further function can be called after that moment, even defer functions cannot be called. That's fine if there's nothing to clean up or the test is simple enough. Though it could be an issue, for example, when a test should print out TAP output by calling `t.AutoPlan()`, or when it should clean up something. So let's try to use `util.Fatal()` only for errors from critical cases like errors from `util.GetDefaultGenerator()` or `util.PrepareBundle()`. In case of main test errors, use instead `t.Fail(err.Error())` to print out errors in TAP outputs. Partly addresses opencontainers#582 /cc @liangchenye Signed-off-by: Dongsu Park <dongsu@kinvolk.io>
dongsupark
pushed a commit
to kinvolk-archives/runtime-tools
that referenced
this issue
Jun 28, 2018
So far `util.Fatal()`, which calls `os.Exit(1)`, has been widely used to exit immediately when a critical error happened. Its downside is though that no further function can be called after that moment, even defer functions cannot be called. That's fine if there's nothing to clean up or the test is simple enough. Though it could be an issue, for example, when a test should print out TAP output by calling `t.AutoPlan()`, or when it should clean up something. So let's try to use `util.Fatal()` only for errors from critical cases like errors from `util.GetDefaultGenerator()` or `util.PrepareBundle()`. In case of main test errors, use instead `t.Fail(err.Error())` to print out errors in TAP outputs. Partly addresses opencontainers#582 /cc @liangchenye Signed-off-by: Dongsu Park <dongsu@kinvolk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In some tests, we are using 'util.Fatal'. It exits immediately, so 'defer' functions will not be called.
We will leave the testing bunde dir or a container.
It needs to be fixed.
The text was updated successfully, but these errors were encountered: